Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis: handle changes to systemd support #88009

Merged
merged 1 commit into from May 17, 2020

Conversation

@JJJollyjim
Copy link
Contributor

JJJollyjim commented May 17, 2020

Motivation for this change

This fixes nixosTests.redis, which has been broken since #87472

The 6.0 changelog notes that systemd support was rewritten. The effects
of that seem to be twofold:

cc @ryantm who was looking at it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
The 6.0 changelog notes that systemd support was rewritten. The effects
of that seem to be twofold:

* Redis will silently fail to sd_notify if not built with libsystemd,
  breaking our unit configuration.
* It also appears to misbehave if told to daemonize when running under
  systemd -- note that upstream's sample unit configuration does not
  daemonize:
  https://github.com/antirez/redis/blob/unstable/utils/systemd-redis_server.service
@adisbladis
Copy link
Member

adisbladis commented May 17, 2020

@GrahamcOfBorg test redis

@JJJollyjim
Copy link
Contributor Author

JJJollyjim commented May 17, 2020

@GrahamcOfBorg test gitlab nextcloud.with-postgresql-and-redis

@adisbladis adisbladis merged commit 1ccc512 into NixOS:master May 17, 2020
20 checks passed
20 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cdc868"; rev="8cdc8687bffd411f6f5b5e458071f18b4c9dd109"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cdc868"; rev="8cdc8687bffd411f6f5b5e458071f18b4c9dd109"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cdc868"; rev="8cdc8687bffd411f6f5b5e458071f18b4c9dd109"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cdc868"; rev="8cdc8687bffd411f6f5b5e458071f18b4c9dd109"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cdc868"; rev="8cdc8687bffd411f6f5b5e458071f18b4c9dd109"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cdc868"; rev="8cdc8687bffd411f6f5b5e458071f18b4c9dd109"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cdc868"; rev="8cdc8687bffd411f6f5b5e458071f18b4c9dd109"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
redis, redis.passthru.tests on aarch64-linux Success
Details
redis, redis.passthru.tests on x86_64-linux Success
Details
tests.gitlab, tests.nextcloud.with-postgresql-and-redis on aarch64-linux Success
Details
tests.gitlab, tests.nextcloud.with-postgresql-and-redis on x86_64-linux Success
Details
tests.redis on aarch64-linux Success
Details
tests.redis on x86_64-linux Success
Details
@JJJollyjim JJJollyjim deleted the JJJollyjim:redis-systemd-fixes branch May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.