Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agda-pkg: init at 0.1.50 #88015

Merged
merged 2 commits into from May 28, 2020
Merged

agda-pkg: init at 0.1.50 #88015

merged 2 commits into from May 28, 2020

Conversation

@alexarice
Copy link
Contributor

alexarice commented May 17, 2020

Motivation for this change

Adds agda-pkg program, which we are experimenting with in #87903 and may also be useful otherwise to people who do not want to use nix infrastructure for agda

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @turion

@alexarice alexarice requested review from FRidh and jonringer as code owners May 17, 2020
@ofborg ofborg bot added the 6.topic: python label May 17, 2020
@alexarice alexarice changed the title Agda pkg init agda-pkg: init at 0.1.49 May 17, 2020
@veprbl
veprbl approved these changes May 26, 2020
pkgs/development/tools/agda-pkg/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/agda-pkg/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/agda-pkg/default.nix Outdated Show resolved Hide resolved
@alexarice alexarice force-pushed the alexarice:agda-pkg-init branch from fa980d8 to db1bed3 May 27, 2020
@alexarice
Copy link
Contributor Author

alexarice commented May 27, 2020

Have addressed comments, thanks for the review

@alexarice alexarice changed the title agda-pkg: init at 0.1.49 agda-pkg: init at 0.1.50 May 27, 2020
@veprbl veprbl merged commit dba97ff into NixOS:master May 28, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
agda-pkg, agda-pkg.passthru.tests on aarch64-linux Success
Details
agda-pkg, agda-pkg.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="db1bed3"; rev="db1bed388503c493fca9387c06981adbd0b86cf1"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="db1bed3"; rev="db1bed388503c493fca9387c06981adbd0b86cf1"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="db1bed3"; rev="db1bed388503c493fca9387c06981adbd0b86cf1"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="db1bed3"; rev="db1bed388503c493fca9387c06981adbd0b86cf1"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="db1bed3"; rev="db1bed388503c493fca9387c06981adbd0b86cf1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="db1bed3"; rev="db1bed388503c493fca9387c06981adbd0b86cf1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="db1bed3"; rev="db1bed388503c493fca9387c06981adbd0b86cf1"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.