Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aflplusplus: 2.64c -> 2.65c #88019

Merged
merged 3 commits into from Jun 4, 2020
Merged

aflplusplus: 2.64c -> 2.65c #88019

merged 3 commits into from Jun 4, 2020

Conversation

@risicle
Copy link
Contributor

risicle commented May 17, 2020

Motivation for this change

New release. Fixes some annoying bugs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Mindavi

risicle added 3 commits May 16, 2020
i don't think running the unit tests really adds anything given that we
have proper integration tests working, and it just introduces another
build dependency and possibility for spurious breakage.
i've successfully built this with llvm 8 and 6 now - make this easier to
override
@Mindavi
Copy link
Contributor

Mindavi commented May 21, 2020

Seems to be running fine on my side, so this is ok. I think it's good there's now an option to choose the clang compiler :).

Edit: remove the question about cmocka, it was in the commit message and I understand the reasoning :)

@risicle
Copy link
Contributor Author

risicle commented May 21, 2020

See the commit comment

i don't think running the unit tests really adds anything given that we have proper integration tests working, and it just introduces another build dependency and possibility for spurious breakage.

@Mindavi
Copy link
Contributor

Mindavi commented Jun 4, 2020

FYI: I did test this as mentioned in my previous comment, so LGTM.

@risicle
Copy link
Contributor Author

risicle commented Jun 4, 2020

Oh cool thanks - my robot brain was just waiting for an "approved" message.

@risicle risicle merged commit d0af797 into NixOS:master Jun 4, 2020
16 checks passed
16 checks passed
aflplusplus, aflplusplus.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
aflplusplus, aflplusplus.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d478d7a"; rev="d478d7a65b359e405b334e4b36845283e7c0b2cf"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d478d7a"; rev="d478d7a65b359e405b334e4b36845283e7c0b2cf"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d478d7a"; rev="d478d7a65b359e405b334e4b36845283e7c0b2cf"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d478d7a"; rev="d478d7a65b359e405b334e4b36845283e7c0b2cf"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d478d7a"; rev="d478d7a65b359e405b334e4b36845283e7c0b2cf"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d478d7a"; rev="d478d7a65b359e405b334e4b36845283e7c0b2cf"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d478d7a"; rev="d478d7a65b359e405b334e4b36845283e7c0b2cf"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.