Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pycuda: bump cudatoolkit dependency, fix boost, fix build #88031

Merged
merged 1 commit into from May 18, 2020

Conversation

@mjlbach
Copy link
Contributor

mjlbach commented May 17, 2020

Motivation for this change

Closes #77563

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mjlbach mjlbach requested review from FRidh and jonringer as code owners May 17, 2020
@mjlbach mjlbach force-pushed the mjlbach:unbreak_pycuda branch from a011b8c to 783c4f6 May 17, 2020
@mjlbach mjlbach mentioned this pull request May 17, 2020
0 of 7 tasks complete
@mjlbach mjlbach changed the title Bump cudatoolkit in pycuda derivation, remove boost dependency Pycuda: bump cudatoolkit dependency, remove boost dependency May 17, 2020
@mjlbach mjlbach changed the title Pycuda: bump cudatoolkit dependency, remove boost dependency Pycuda: bump cudatoolkit dependency, remove boost, fix build May 17, 2020
@mjlbach mjlbach force-pushed the mjlbach:unbreak_pycuda branch from 783c4f6 to 3038daa May 17, 2020
@mjlbach mjlbach changed the title Pycuda: bump cudatoolkit dependency, remove boost, fix build Pycuda: bump cudatoolkit dependency, fix boost, fix build May 17, 2020
@mjlbach mjlbach force-pushed the mjlbach:unbreak_pycuda branch from 3038daa to cf5dcbf May 17, 2020
@mjlbach
Copy link
Contributor Author

mjlbach commented May 17, 2020

I tested on python 2 and python3 with the examples from the pycuda repo, and it seems to work

@bhipple
Copy link
Contributor

bhipple commented May 18, 2020

Result of nixpkgs-review pr 88031 1

3 packages built:
- python27Packages.pycuda
- python37Packages.pycuda
- python38Packages.pycuda
@bhipple bhipple merged commit f648016 into NixOS:master May 18, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cf5dcbf"; rev="cf5dcbf49f8fa97cb5a1f02a9c3ff224ec392228"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cf5dcbf"; rev="cf5dcbf49f8fa97cb5a1f02a9c3ff224ec392228"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cf5dcbf"; rev="cf5dcbf49f8fa97cb5a1f02a9c3ff224ec392228"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cf5dcbf"; rev="cf5dcbf49f8fa97cb5a1f02a9c3ff224ec392228"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cf5dcbf"; rev="cf5dcbf49f8fa97cb5a1f02a9c3ff224ec392228"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cf5dcbf"; rev="cf5dcbf49f8fa97cb5a1f02a9c3ff224ec392228"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cf5dcbf"; rev="cf5dcbf49f8fa97cb5a1f02a9c3ff224ec392228"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.