Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processing: 3.5.3 -> 3.5.4 | fix / refactor #88034

Open
wants to merge 4 commits into
base: master
from

Conversation

@9999years
Copy link
Contributor

9999years commented May 17, 2020

The old expression downloaded http://download.processing.org/reference.zip with a fixed hash, and would break when new versions were released.

This expression remedies that by using a versioned tarball.

Further, it avoids compiling by applying our patch (to avoid the spurious "Not fond of this Java VM" warning message) directly to the compiled .class file.

Motivation for this change

The old processing expression was broken by a change to http://download.processing.org/reference.zip.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@lourkeur
Copy link
Contributor

lourkeur commented May 18, 2020

Builds and launches well on NixOS x86_64 provided an oraclejdk8. Some of my sketches have issues with libraries, but that's still better than status quo. Nicely done with the bytecode patch. LGTM

Copy link
Contributor

lourkeur left a comment

Also works on i686-linux afaict

@lourkeur
Copy link
Contributor

lourkeur commented May 18, 2020

@9999years
Copy link
Contributor Author

9999years commented May 18, 2020

Want me to squash those nit fixes up?

@lourkeur
Copy link
Contributor

lourkeur commented May 18, 2020

Yes I think it'd be nice.

9999years added 3 commits May 17, 2020
The old expression downloaded
`http://download.processing.org/reference.zip` with a fixed hash, and
would break when new versions were released.

This expression remedies that by using a versioned tarball.

Further, it avoids compiling by applying our patch (to avoid the
spurious "Not fond of this Java VM" warning message) directly to the
compiled `.class` file.
Co-authored-by: Louis Bettens <lourkeur@users.noreply.github.com>

Use fetchzip instead of fetchTarball

Co-authored-by: Louis Bettens <lourkeur@users.noreply.github.com>

Use xorg instead of xlibs

Use xorg instead of xlibs

Use xorg instead of xlibs
Abstracting out values from the bytecode patch / making it
toggleable guards against future changes breaking the derivation.
@9999years 9999years force-pushed the 9999years:master branch from 14a5e56 to 1b2a1c4 May 18, 2020
- Arguments to `lib.map` were reversed.
- `mkDerivation` complained about stringifying a set; use variables
  prefixed with `popup` instead.
@9999years
Copy link
Contributor Author

9999years commented May 20, 2020

OK, got those bugs fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.