Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reaper: update to 6.10, fix libjack2 missing dependency #88049

Merged
merged 2 commits into from May 24, 2020
Merged

Conversation

@gnidorah
Copy link
Member

gnidorah commented May 18, 2020

Motivation for this change

Closes #79763
Closes #80486

cc @bignaux @t-cip

jack

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Bignaux Ronan and others added 2 commits Feb 28, 2020
@gnidorah gnidorah requested review from jfrankenau and worldofpeace May 18, 2020
@gnidorah gnidorah mentioned this pull request May 18, 2020
3 of 10 tasks complete
@veprbl
veprbl approved these changes May 24, 2020
@veprbl veprbl merged commit 03aca5b into NixOS:master May 24, 2020
16 checks passed
16 checks passed
reaper, reaper.passthru.tests on aarch64-linux No attempt
Details
reaper, reaper.passthru.tests on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f748fae"; rev="f748fae91c588481b91f33690c208d366506983f"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f748fae"; rev="f748fae91c588481b91f33690c208d366506983f"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f748fae"; rev="f748fae91c588481b91f33690c208d366506983f"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f748fae"; rev="f748fae91c588481b91f33690c208d366506983f"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f748fae"; rev="f748fae91c588481b91f33690c208d366506983f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f748fae"; rev="f748fae91c588481b91f33690c208d366506983f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f748fae"; rev="f748fae91c588481b91f33690c208d366506983f"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@gnidorah
Copy link
Member Author

gnidorah commented May 25, 2020

@veprbl Thank you!

@gnidorah gnidorah deleted the gnidorah:reaper branch May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.