Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitea: fix wiki template incompatibility with go 1.14 #88057

Merged
merged 1 commit into from May 18, 2020

Conversation

@pvgoran
Copy link
Contributor

pvgoran commented May 18, 2020

More go 1.14 related fixes for wiki pages (this time, the revision page was fixed). Related to #87115.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@pvgoran
Copy link
Contributor Author

pvgoran commented May 18, 2020

ping @Ma27

@Ma27 Ma27 merged commit 39d2c57 into NixOS:master May 18, 2020
@Ma27
Copy link
Member

Ma27 commented May 18, 2020

Thanks! Also ported to stable: 94492e8

@pvgoran
Copy link
Contributor Author

pvgoran commented May 18, 2020

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.