Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffsend: 0.2.61 -> 0.2.64 #88063

Merged
merged 1 commit into from May 19, 2020
Merged

ffsend: 0.2.61 -> 0.2.64 #88063

merged 1 commit into from May 19, 2020

Conversation

@filalex77
Copy link
Contributor

filalex77 commented May 18, 2020

Motivation for this change

https://github.com/timvisee/ffsend/releases/tag/v0.2.64

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@lilyball
Copy link
Member

lilyball commented May 18, 2020

openssl is no longer required on macOS and Windows, but is still required on Linux and FreeBSD (apparently this is because of an indirect dependency that's pulling it in). We should probably update the Nix dependencies accordingly.

@lilyball
Copy link
Member

lilyball commented May 18, 2020

We could also opt to enable a feature that restores direct usage of openssl everywhere (default now is to use ring instead), but I don't see any benefit to doing that.

Copy link
Contributor

jonringer left a comment

LGTM

Result of nixpkgs-review pr 88063 1

1 package built: - ffsend

@jonringer jonringer merged commit c34d4bb into NixOS:master May 19, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
ffsend, ffsend.passthru.tests on aarch64-linux Success
Details
ffsend, ffsend.passthru.tests on x86_64-darwin Success
Details
ffsend, ffsend.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5ea9cd4"; rev="5ea9cd4e2da32ad628ba1a34970356556b6a903c"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5ea9cd4"; rev="5ea9cd4e2da32ad628ba1a34970356556b6a903c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5ea9cd4"; rev="5ea9cd4e2da32ad628ba1a34970356556b6a903c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5ea9cd4"; rev="5ea9cd4e2da32ad628ba1a34970356556b6a903c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5ea9cd4"; rev="5ea9cd4e2da32ad628ba1a34970356556b6a903c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5ea9cd4"; rev="5ea9cd4e2da32ad628ba1a34970356556b6a903c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5ea9cd4"; rev="5ea9cd4e2da32ad628ba1a34970356556b6a903c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.