Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zxing-cpp: init at latest commit from march-20-2019 #88065

Closed
wants to merge 2 commits into from

Conversation

@SCOTT-HAMILTON
Copy link
Contributor

SCOTT-HAMILTON commented May 18, 2020

Motivation for this change

Zxing-cpp is a dependency of OTPGen which is packaged in this PR #87887

Things done

Packaged https://github.com/glassechidna/zxing-cpp from latest commit.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SCOTT-HAMILTON SCOTT-HAMILTON mentioned this pull request May 18, 2020
0 of 8 tasks complete
@wamserma
Copy link
Contributor

wamserma commented May 18, 2020

FWIW the project seems to be a bit neglected. Not sure if it is worth packaging it.

@SCOTT-HAMILTON
Copy link
Contributor Author

SCOTT-HAMILTON commented May 18, 2020

The only resean for me to package it is to fix this issue #87887 (comment).
But if it doesn't make sense to do so then I think the best is to close this and keep the bundled lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.