Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicorn-emulator-git: init at unstable-2020-05-18 #88069

Closed
wants to merge 1 commit into from

Conversation

@IvarWithoutBones
Copy link
Contributor

IvarWithoutBones commented May 18, 2020

Motivation for this change

Required for #84117, as the latest release is quite old. The changes we need are already in master, however not in the latest release from 2017. Could also update to a pre-release, however i thought it'd be better to keep the base package at a stable release, and just have an unstable git package as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@IvarWithoutBones
Copy link
Contributor Author

IvarWithoutBones commented May 18, 2020

Oh, apologies. This does not work, i forgot to enable the CMake flag to enable a system provided unicorn package in the project stated above. Project build fine as it was using unicorn from externals, so i thought this did the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.