Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find-libs: extract from stage-1 and turn into its own package #88070

Draft
wants to merge 1 commit into
base: master
from

Conversation

@ryantrinkle
Copy link
Contributor

ryantrinkle commented May 18, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • [N/A] macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Remaining work

This PR is in a draft state primarily because I have not yet tested that NixOS's stage-1 bootloader still works. Although this is a fairly simple extraction of code from one place to another, it is critical that this be fully tested before it is merged.

  • Test that NixOS stage-1 bootloader still works identically to before
  • Add package metadata for find-libs
  • Decide whether find-libs is the correct name for this
@@ -290,6 +290,8 @@ in

fetchMavenArtifact = callPackage ../build-support/fetchmavenartifact { };

find-libs = callPackage ../development/tools/misc/find-libs { };

This comment has been minimized.

Copy link
@Mic92

Mic92 May 18, 2020

Contributor

What is the use case for this? Note there are other tools like ldd-tree if you just want to use it as a tool.

This comment has been minimized.

Copy link
@ryantrinkle

ryantrinkle May 27, 2020

Author Contributor

I built this tool using it: https://gist.github.com/ryantrinkle/ad2cea1435b813ebd3498a950bc11f9a

I'd be very happy to know if there's a better way to do that, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.