Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmilter: fix compilation on Darwin #88075

Merged
merged 4 commits into from Jun 11, 2020
Merged

libmilter: fix compilation on Darwin #88075

merged 4 commits into from Jun 11, 2020

Conversation

@mroi
Copy link
Contributor

mroi commented May 18, 2020

This PR fixes compilation of libmilter on Darwin.

Motivation for this change

I am trying to enable compilation of clamav on Darwin and libmilter is a prerequisite.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
mroi added 4 commits May 18, 2020
MILTER_SOVER is used as an environment variable during the build, but never set anywhere
set to so version 1 as currently used by Ubuntu
defaults to ‘so’ if not set
* configure compilation options
* patch sendmail.h header inclusion
@ofborg ofborg bot added the 6.topic: darwin label May 18, 2020
@ofborg ofborg bot requested a review from fpletz May 18, 2020
@matthewbauer matthewbauer merged commit d659f96 into NixOS:master Jun 11, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cb38977"; rev="cb38977986f9068fbba0a7e483a8ccbcd45f43ec"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cb38977"; rev="cb38977986f9068fbba0a7e483a8ccbcd45f43ec"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cb38977"; rev="cb38977986f9068fbba0a7e483a8ccbcd45f43ec"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cb38977"; rev="cb38977986f9068fbba0a7e483a8ccbcd45f43ec"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cb38977"; rev="cb38977986f9068fbba0a7e483a8ccbcd45f43ec"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cb38977"; rev="cb38977986f9068fbba0a7e483a8ccbcd45f43ec"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cb38977"; rev="cb38977986f9068fbba0a7e483a8ccbcd45f43ec"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libmilter, libmilter.passthru.tests on aarch64-linux Success
Details
libmilter, libmilter.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.