Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libexif: 0.6.21 -> 0.6.22 #88096

Closed
wants to merge 1 commit into from
Closed

libexif: 0.6.21 -> 0.6.22 #88096

wants to merge 1 commit into from

Conversation

@mmilata
Copy link
Member

mmilata commented May 18, 2020

Changes: https://github.com/libexif/libexif/releases/tag/libexif-0_6_22-release

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mmilata
Copy link
Member Author

mmilata commented May 18, 2020

The autoconf error seems to be due to #87705?

@jonringer jonringer mentioned this pull request May 19, 2020
2 of 10 tasks complete
@mmilata mmilata force-pushed the mmilata:libexif-0.6.22 branch from a88a4d4 to a5cfb36 May 19, 2020
@jtojnar
Copy link
Contributor

jtojnar commented May 31, 2020

@erictapen
Copy link
Contributor

erictapen commented May 31, 2020

@mmilata suggested to merge #88100 instead, as it uses fetchFromGitHub and supports cross compilation, so I'd close this PR. @prusnak could you imagine also reviewing #88100?

@erictapen erictapen closed this May 31, 2020
@mmilata mmilata deleted the mmilata:libexif-0.6.22 branch May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.