Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libexif: 0.6.21 -> 0.6.22 #88100

Merged
merged 1 commit into from Jun 4, 2020
Merged

libexif: 0.6.21 -> 0.6.22 #88100

merged 1 commit into from Jun 4, 2020

Conversation

@erictapen
Copy link
Contributor

erictapen commented May 18, 2020

Motivation for this change
Things done
  • Bumped libexif
  • removed old patches that are now integrated in the release (see also the NEWS for that)
  • enabled building from git sources
  • made sure cross compilation works
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

jonringer left a comment

since this change causes over 500 rebuilds, do you mind targeting the staging branch

git rebase --onto=staging HEAD~1
git push .. ... --force

then change the base branch in the github PR from master -> staging

See https://nixos.org/nixpkgs/manual/#submitting-changes-staging-branch for more details on staging branch

@jonringer
Copy link
Contributor

jonringer commented May 19, 2020

also, duplicate of #88096

@mmilata
Copy link
Contributor

mmilata commented May 19, 2020

In #88096 I didn't look into cross compilation so it's probably better to merge this one.

Another difference is that the other PR uses the release archive which doesn't need autoreconf, not sure what is preferable.

@erictapen erictapen changed the base branch from master to staging May 19, 2020
@erictapen erictapen force-pushed the erictapen:libexif-0.6.22 branch from 21c9b31 to 1d3149e May 19, 2020
@erictapen
Copy link
Contributor Author

erictapen commented May 19, 2020

@mmilata Oh sorry, this time I didn't look for duplicates because I felt I'd be early enough. Will check next time definetely.

I'd always prefer building from source, as this leverages the hurdle for upstream contributions.

@jonringer Thanks, I know about the staging branch but first wanted to ask ofBorg how much is going to be rebuilt.

@erictapen erictapen mentioned this pull request May 31, 2020
3 of 10 tasks complete
pkgs/development/libraries/libexif/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libexif/default.nix Outdated Show resolved Hide resolved
Also:
- build from git
- enable cross compilation
@erictapen erictapen force-pushed the erictapen:libexif-0.6.22 branch from 1d3149e to a31129d Jun 1, 2020
@erictapen
Copy link
Contributor Author

erictapen commented Jun 1, 2020

@prusnak Thanks for the review. I added your suggestions and rebased to latest staging.

@prusnak
prusnak approved these changes Jun 1, 2020
@FRidh FRidh merged commit e761cfe into NixOS:staging Jun 4, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a31129d"; rev="a31129dc069a1c42d600b7bf111b8237f8b72f92"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a31129d"; rev="a31129dc069a1c42d600b7bf111b8237f8b72f92"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a31129d"; rev="a31129dc069a1c42d600b7bf111b8237f8b72f92"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a31129d"; rev="a31129dc069a1c42d600b7bf111b8237f8b72f92"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a31129d"; rev="a31129dc069a1c42d600b7bf111b8237f8b72f92"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a31129d"; rev="a31129dc069a1c42d600b7bf111b8237f8b72f92"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a31129d"; rev="a31129dc069a1c42d600b7bf111b8237f8b72f92"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libexif, libexif.passthru.tests on aarch64-linux Success
Details
libexif, libexif.passthru.tests on x86_64-linux Success
Details
@erictapen erictapen mentioned this pull request Jun 18, 2020
2 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.