Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.azure*: bump, azure-cli: 2.40 -> 2.5.1 #88103

Merged
merged 10 commits into from May 19, 2020

Conversation

@jonringer
Copy link
Contributor

jonringer commented May 18, 2020

Motivation for this change

It was out of date

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
jonringer added 10 commits May 18, 2020
@jonringer jonringer requested a review from FRidh as a code owner May 18, 2020
@ofborg ofborg bot added the 6.topic: python label May 18, 2020
@ofborg ofborg bot requested a review from olcai May 18, 2020
Copy link
Contributor

drewrisinger left a comment

Diff LGTM.
Result of nix-review pr 88103:

2 package marked as broken and skipped:
fluidasserts python37Packages.fluidasserts

17 package built:
azure-cli python27Packages.azure-mgmt-batch python27Packages.azure-mgmt-cosmosdb python27Packages.azure-mgmt-eventhub python27Packages.azure-mgmt-iothub python27Packages.azure-mgmt-network python27Packages.azure-mgmt-storage python27Packages.azure-servicefabric python37Packages.azure-mgmt-batch python37Packages.azure-mgmt-core python37Packages.azure-mgmt-cosmosdb python37Packages.azure-mgmt-eventhub python37Packages.azure-mgmt-iothub python37Packages.azure-mgmt-network python37Packages.azure-mgmt-storage python37Packages.azure-multiapi-storage python37Packages.azure-servicefabric
@jonringer jonringer merged commit 5e82ba4 into NixOS:master May 19, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
azure-cli, azure-cli.passthru.tests on aarch64-linux Success
Details
azure-cli, azure-cli.passthru.tests on x86_64-darwin Success
Details
azure-cli, azure-cli.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e0b07e"; rev="2e0b07e33355b8557553c843038602efe141a8d0"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e0b07e"; rev="2e0b07e33355b8557553c843038602efe141a8d0"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e0b07e"; rev="2e0b07e33355b8557553c843038602efe141a8d0"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e0b07e"; rev="2e0b07e33355b8557553c843038602efe141a8d0"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e0b07e"; rev="2e0b07e33355b8557553c843038602efe141a8d0"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e0b07e"; rev="2e0b07e33355b8557553c843038602efe141a8d0"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e0b07e"; rev="2e0b07e33355b8557553c843038602efe141a8d0"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.