Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrapNeovim: consolidate makeWrapper arguments and more #88110

Open
wants to merge 5 commits into
base: master
from

Conversation

@doronbehar
Copy link
Contributor

doronbehar commented May 19, 2020

Motivation for this change

After discussion in #87929 I wanted to show how we can get the man page for Neovim installed in user environment, along with pretty much every other file Neovim pushes, and also make sure we don't get nvim double wrapped if configure != {} (argument given to the wrapper).

All of this was done while repetitions were reduced to a minumum, and hopefully it's now easier to maintain this wrapper.

cc @0paIescent for testing. I think most arguments wrapGeneric should know how to handle are taken care of but I haven't tested every possible option or every possible combination of arguments there is.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
doronbehar added 5 commits May 19, 2020
Also: Removed unneeded neovim.meta.description reset.
Why would `${neovim}/bin/nvim` not exist?
This way we can be sure that all support files that Neovim installs by
default are available in the user environment - these include man pages
which weren't copied like other files originally.
Compute all arguments to makeWrapper in pure Nix "before" `postBuild`
And thus prevent double wrapping in case `configure != {}`.
@doronbehar
Copy link
Contributor Author

doronbehar commented May 22, 2020

@GrahamcOfBorg build neovim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.