Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libarchive: fix build #88111

Closed
wants to merge 1 commit into from
Closed

libarchive: fix build #88111

wants to merge 1 commit into from

Conversation

@marsam
Copy link
Contributor

marsam commented May 19, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@emilazy
Copy link
Member

emilazy commented May 19, 2020

cc @jtojnar @Ericson2314 were talking about this on #nixos-dev

Do you know have any idea what a fix would be to make this work with autoreconfHook? Presumably some packages might need patching due to the unavailability of a binary configure generated with an older version of autoconf.

@Ericson2314
Copy link
Member

Ericson2314 commented May 19, 2020

Yeah I am curious what the underlying issue is, and would rather fix that if possible, as I saw it crop up with other packages.

@jtojnar
Copy link
Contributor

jtojnar commented May 20, 2020

I agree but libarchive is currently blocking staging CI so I would like to merge this as is for now.

@jtojnar
Copy link
Contributor

jtojnar commented May 20, 2020

Bisection leads me to

Author: John Ericson <John.Ericson@Obsidian.Systems>
Date:   Mon Apr 27 22:39:58 2020 -0400

    pkg-config-wrapper: Init
    
    This fixes longstanding build issues

 pkgs/build-support/pkg-config-wrapper/add-flags.sh |  12 +++
 pkgs/build-support/pkg-config-wrapper/default.nix  | 117 +++++++++++++++++++++
 .../pkg-config-wrapper/pkg-config-wrapper.sh       |  21 ++++
 .../build-support/pkg-config-wrapper/setup-hook.sh |  29 +++++
 .../python-modules/pkgconfig/default.nix           |   2 +-
 pkgs/development/tools/misc/pkg-config/default.nix |   2 -
 .../tools/misc/pkg-config/setup-hook.sh            |   6 --
 pkgs/test/cross/default.nix                        |  14 +++
 pkgs/top-level/all-packages.nix                    |  17 ++-
 9 files changed, 208 insertions(+), 12 deletions(-)
 create mode 100644 pkgs/build-support/pkg-config-wrapper/add-flags.sh
 create mode 100644 pkgs/build-support/pkg-config-wrapper/default.nix
 create mode 100644 pkgs/build-support/pkg-config-wrapper/pkg-config-wrapper.sh
 create mode 100644 pkgs/build-support/pkg-config-wrapper/setup-hook.sh
 delete mode 100644 pkgs/development/tools/misc/pkg-config/setup-hook.sh
@Ericson2314
Copy link
Member

Ericson2314 commented May 21, 2020

Ah! Well, then it's on me to fix :) If I don't get it done quick I'll merge this.

@Ericson2314
Copy link
Member

Ericson2314 commented May 21, 2020

Found the issue: my wrapper left the pkg-config share/ behind. Fixing now.

@Ericson2314
Copy link
Member

Ericson2314 commented May 21, 2020

Got it, see #88518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.