Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.vulkan: unbreak vulkan #88130

Merged
merged 1 commit into from May 19, 2020

Conversation

@poscat0x04
Copy link
Contributor

poscat0x04 commented May 19, 2020

Motivation for this change

This package builds just fine, not sure why is it listed as broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@poscat0x04 poscat0x04 requested a review from cdepillabout as a code owner May 19, 2020
@cdepillabout
Copy link
Member

cdepillabout commented May 19, 2020

The links in this post should give some info as to how the haskell-updates branch works, and why things gets marked as broken: https://discourse.nixos.org/t/call-to-action-for-updating-haskell-packages-after-bump-to-lts-15/6071

@cdepillabout
Copy link
Member

cdepillabout commented May 19, 2020

Looks good, builds for me.

Thanks!

@cdepillabout cdepillabout merged commit e1524e0 into NixOS:haskell-updates May 19, 2020
1 check failed
1 check failed
grahamcofborg-eval The branch this PR will merge in to does not cleanly evaluate, and so this PR cannot be checked.
Details
@poscat0x04 poscat0x04 deleted the poscat0x04:unbreak-vulkan branch Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.