Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samba: 4.12.2 -> 4.12.3 #88165

Merged
merged 1 commit into from May 23, 2020
Merged

Samba: 4.12.2 -> 4.12.3 #88165

merged 1 commit into from May 23, 2020

Conversation

@sjau
Copy link
Contributor

sjau commented May 19, 2020

Motivation for this change

Samba 4.12.2 -> 4.12.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@adisbladis
Copy link
Member

adisbladis commented May 23, 2020

@GrahamcOfBorg test samba

@sjau sjau force-pushed the sjau:samba-4.12.3 branch from 102991b to 0f168da May 23, 2020
@adisbladis adisbladis force-pushed the sjau:samba-4.12.3 branch from 0f168da to ec756db May 23, 2020
@adisbladis adisbladis merged commit dcd6887 into NixOS:master May 23, 2020
1 check was pending
1 check was pending
grahamcofborg-eval Checking original out paths
Details
@sjau sjau deleted the sjau:samba-4.12.3 branch May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.