Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] Backport LLVM big-parallel and ghostscript patch #88169

Closed
wants to merge 5 commits into from

Conversation

@bennofs
Copy link
Contributor

bennofs commented May 19, 2020

Motivation for this change

Backport of LLVM and Ghostscript changes from master to 20.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
bennofs added 5 commits Apr 26, 2020
The build process of ghostscript has missing dependencies, causing
failures in parallel builds (see hydra build
https://hydra.nixos.org/build/117095669/, reported as ghostscript bug
https://bugs.ghostscript.com/show_bug.cgi?id=702364 here)

(cherry picked from commit 260be73)
LLVM builds frequently time out on hydra at least on AArch64. Marking
big-parallel gives them more resources to finish quicker.

(cherry picked from commit 8c880d9)
LLVM builds frequently time out on hydra at least on AArch64. Marking
big-parallel gives them more resources to finish quicker.

(cherry picked from commit 4b3c3e1)
LLVM builds frequently time out on hydra at least on AArch64. Marking
big-parallel gives them more resources to finish quicker.

(cherry picked from commit 7c27e87)
LLVM builds frequently time out on hydra at least on AArch64. Marking
big-parallel gives them more resources to finish quicker.

(cherry picked from commit ed2ac0d)
@symphorien
Copy link
Contributor

symphorien commented May 19, 2020

backporting big-parallel looks like a breaking change to me...

@bennofs
Copy link
Contributor Author

bennofs commented May 19, 2020

Why would that be breaking? I thought that's just for allocating hydra shares

@symphorien
Copy link
Contributor

symphorien commented May 19, 2020

It affects all setups using remote building, not only hydra.

@bennofs
Copy link
Contributor Author

bennofs commented Jun 3, 2020

Hmm, looks like the builds for release-20.03 work on hydra now. So maybe we don't need the backport. Closing this for now.

@bennofs bennofs closed this Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.