Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-synapse: 1.12.4 -> 1.13.0, riot-{web,desktop}: 1.6.0 -> 1.6.1 #88171

Merged
merged 3 commits into from May 20, 2020

Conversation

@Ma27
Copy link
Member

Ma27 commented May 19, 2020

Motivation for this change

Some Matrix-related updates:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@fadenb
fadenb approved these changes May 19, 2020
Ma27 added 2 commits May 19, 2020
https://github.com/vector-im/riot-desktop/releases/tag/v1.6.1

Also updated the package since `riot-desktop` has been moved to its own
repository (`github.com/vector-im/riot-desktop`).
@Ma27 Ma27 force-pushed the Ma27:matrix-updates branch from 83dbf27 to 2a5b0bc May 19, 2020
@Ekleog
Ekleog approved these changes May 19, 2020
@mweinelt
Copy link
Member

mweinelt commented May 19, 2020

Result of nixpkgs-review pr 88171 1

2 packages built:
- matrix-synapse
- riot-desktop
Copy link
Member

mweinelt left a comment

Quickly tested riot-desktop and seemed fine.

@blitz
Copy link
Contributor

blitz commented May 19, 2020

I gave riot-desktop a spin and didn't notice any issues.

@blitz
blitz approved these changes May 19, 2020
@srhb srhb merged commit 0fc9fc0 into NixOS:master May 20, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a5b0bc"; rev="2a5b0bc813a1348c2724c2529e66f60b5a3d5fa8"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a5b0bc"; rev="2a5b0bc813a1348c2724c2529e66f60b5a3d5fa8"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a5b0bc"; rev="2a5b0bc813a1348c2724c2529e66f60b5a3d5fa8"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a5b0bc"; rev="2a5b0bc813a1348c2724c2529e66f60b5a3d5fa8"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a5b0bc"; rev="2a5b0bc813a1348c2724c2529e66f60b5a3d5fa8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a5b0bc"; rev="2a5b0bc813a1348c2724c2529e66f60b5a3d5fa8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2a5b0bc"; rev="2a5b0bc813a1348c2724c2529e66f60b5a3d5fa8"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
matrix-synapse, matrix-synapse.passthru.tests, riot-desktop, riot-desktop.passthru.tests on aarch64-linux Success
Details
matrix-synapse, matrix-synapse.passthru.tests, riot-desktop, riot-desktop.passthru.tests on x86_64-darwin Success
Details
matrix-synapse, matrix-synapse.passthru.tests, riot-desktop, riot-desktop.passthru.tests on x86_64-linux Success
Details
@Ma27 Ma27 deleted the Ma27:matrix-updates branch May 20, 2020
@Ma27 Ma27 mentioned this pull request May 20, 2020
4 of 10 tasks complete
@Ma27
Copy link
Member Author

Ma27 commented May 20, 2020

Ported the riot-* updates to stable: 5d12be8, 0436b0d

Also opened a backport PR for matrix-synapse since this the release has some non-trivial changes and I'd prefer to get a review on this first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.