Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualbox: 6.1.6 -> 6.1.8 #88172

Closed
wants to merge 1 commit into from
Closed

virtualbox: 6.1.6 -> 6.1.8 #88172

wants to merge 1 commit into from

Conversation

@nthorne
Copy link
Contributor

nthorne commented May 19, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Niklas Thorne
@blitz
blitz approved these changes May 19, 2020
Copy link
Contributor

blitz left a comment

Looks good from my end.

@B4dM4n
B4dM4n approved these changes May 22, 2020
Copy link
Contributor

B4dM4n left a comment

Looks good to me.

Linux and Windows VMs are running as expected.

@nthorne nthorne mentioned this pull request Jun 8, 2020
1 of 10 tasks complete
@nthorne
Copy link
Contributor Author

nthorne commented Jun 8, 2020

Made obsolete by pull request #89798

@flokli
Copy link
Contributor

flokli commented Jun 21, 2020

Closing in favor of #89798.

@flokli flokli closed this Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.