Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpiboot-unstable: 2018-03-27 -> 2020-02-17 #88174

Closed
wants to merge 1 commit into from

Conversation

@wamserma
Copy link
Contributor

@wamserma wamserma commented May 19, 2020

Motivation for this change

Upstream added support for RPi 4, fixed a few bugs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@cartr
Copy link
Contributor

@cartr cartr commented Jun 9, 2020

Very sorry about the delay in reviewing! To be honest, I don't actually have a NixOS system or Raspberry Pi handy anymore to test this change. @dezgeg @tavyc would either of you be up to take over maintaining this package?

Also note that #88174 appears to bump rpiboot-unstable's version as well.

@wamserma
Copy link
Contributor Author

@wamserma wamserma commented Jun 9, 2020

Very sorry about the delay in reviewing! To be honest, I don't actually have a NixOS system or Raspberry Pi handy anymore to test this change. @dezgeg @tavyc would either of you be up to take over maintaining this package?

Yes, someone with a RPi at hand would be really useful for testing this. :)

On the other hand: If you got some other Linux System (maybe even WSL2) with Nix installed you can at least test compilation and invocation with nix-shell -p nixpkgs-review --run "nixpkgs-review 88174".

Also note that #88174 appears to bump rpiboot-unstable's version as well.

Don't worry, this will resolve automagically. ;)

@wamserma
Copy link
Contributor Author

@wamserma wamserma commented Jul 10, 2020

/marvin opt-in
/status needs-reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Jul 10, 2020
@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Jul 10, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@wamserma
Copy link
Contributor Author

@wamserma wamserma commented Jul 10, 2020

/status needs_reviewer

@mohe2015
Copy link

@mohe2015 mohe2015 commented Jul 25, 2020

I think this pull request can be closed as the version in master seems to be more recent.

@wamserma
Copy link
Contributor Author

@wamserma wamserma commented Jul 26, 2020

Closed by 271a9a0

@wamserma wamserma closed this Jul 26, 2020
@wamserma wamserma deleted the wamserma:rpiboot-bump branch Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.