Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zenith: 0.8.2 -> 0.9.0 #88185

Merged
merged 1 commit into from May 22, 2020
Merged

zenith: 0.8.2 -> 0.9.0 #88185

merged 1 commit into from May 22, 2020

Conversation

@bbigras
Copy link
Contributor

bbigras commented May 19, 2020

0.9.0 has "not built by default" support for nvidia gpu but I didn't figure out yet how to build it. I'll address it in another PR.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/14knjny0mplcs3js2ivr9vjzdwcznsx6-zenith-0.8.2 34.8M
/nix/store/1jwqjrk3w4fnqi3nacf84nlc6raavhd6-zenith-0.9.0 33.8M

@bbigras
Copy link
Contributor Author

bbigras commented May 19, 2020

It should build for aarch64 this time.

@bbigras
Copy link
Contributor Author

bbigras commented May 19, 2020

It doesn't build on aarch64. Help would be very welcome.

@nixos-discourse
Copy link

nixos-discourse commented May 22, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/21

@doronbehar
Copy link
Contributor

doronbehar commented May 22, 2020

As a start, I'd try to split to two different PRs the update vs "Make this work for aarch64".

@bbigras bbigras force-pushed the bbigras:zenith branch from 9440d21 to a3a285a May 22, 2020
@bbigras bbigras mentioned this pull request May 22, 2020
0 of 10 tasks complete
@bbigras
Copy link
Contributor Author

bbigras commented May 22, 2020

@doronbehar done, this PR is the update and the aarch64 stuff is in #88616.

Copy link
Contributor

doronbehar left a comment

Seems to work fine on x86-linux.

@bbigras
Copy link
Contributor Author

bbigras commented May 22, 2020

Thank you very much for your time.

@marsam marsam merged commit 44d9c9f into NixOS:master May 22, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a3a285a"; rev="a3a285af0ff0837b701f6a629aa040b59af30083"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a3a285a"; rev="a3a285af0ff0837b701f6a629aa040b59af30083"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a3a285a"; rev="a3a285af0ff0837b701f6a629aa040b59af30083"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a3a285a"; rev="a3a285af0ff0837b701f6a629aa040b59af30083"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a3a285a"; rev="a3a285af0ff0837b701f6a629aa040b59af30083"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a3a285a"; rev="a3a285af0ff0837b701f6a629aa040b59af30083"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a3a285a"; rev="a3a285af0ff0837b701f6a629aa040b59af30083"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@bbigras bbigras deleted the bbigras:zenith branch May 23, 2020
@bbigras
Copy link
Contributor Author

bbigras commented May 23, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.