Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usbguard: 0.7.6 -> 0.7.8 + systemd service update #88193

Merged
merged 3 commits into from May 24, 2020
Merged

Conversation

@tnias
Copy link
Contributor

tnias commented May 19, 2020

Motivation for this change

Update to latest USBGuard release and use upstream systemd service sandboxing.

https://github.com/USBGuard/usbguard/releases/tag/usbguard-0.7.7
https://github.com/USBGuard/usbguard/releases/tag/usbguard-0.7.8

Things done

I tested basic functionality. Such as allowing devices and writing persistent rules via usbguard append-rule ....

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@tnias tnias changed the title usbguard 0.7.6 -> 0.7.7 + systemd service update usbguard: 0.7.6 -> 0.7.7 + systemd service update May 19, 2020
@tnias tnias changed the title usbguard: 0.7.6 -> 0.7.7 + systemd service update usbguard: 0.7.6 -> 0.7.8 + systemd service update May 20, 2020
Copy link
Contributor

bjornfor left a comment

Nitpick: typo in a commit message: sanboxing -> sandboxing.

tnias added 2 commits May 19, 2020
Apply upstream systemd service configuration options to improve
sandboxing.
@tnias tnias force-pushed the tnias:usbguard_077 branch from dbdf32c to 42675a3 May 24, 2020
@tnias
Copy link
Contributor Author

tnias commented May 24, 2020

typo fixed

@bjornfor bjornfor merged commit 20ebb13 into NixOS:master May 24, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42675a3"; rev="42675a3e2c58270d09339b3d49902d9e92eb41e8"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42675a3"; rev="42675a3e2c58270d09339b3d49902d9e92eb41e8"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42675a3"; rev="42675a3e2c58270d09339b3d49902d9e92eb41e8"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42675a3"; rev="42675a3e2c58270d09339b3d49902d9e92eb41e8"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42675a3"; rev="42675a3e2c58270d09339b3d49902d9e92eb41e8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42675a3"; rev="42675a3e2c58270d09339b3d49902d9e92eb41e8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42675a3"; rev="42675a3e2c58270d09339b3d49902d9e92eb41e8"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
usbguard, usbguard.passthru.tests on aarch64-linux Success
Details
usbguard, usbguard.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.