Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omnisharp-roslyn: 1.35.0 -> 1.35.1 #88198

Merged
merged 2 commits into from May 24, 2020

Conversation

@r-ryantm
Copy link
Contributor

r-ryantm commented May 19, 2020

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/OmniSharp/omnisharp-roslyn/releases.

meta.description for omnisharp-roslyn is: "OmniSharp based on roslyn workspaces"

meta.homepage for omnisharp-roslyn is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
omnisharp-roslyn
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/hl897zmcr3ykkq5ghp1wggnira3k7vi7-omnisharp-roslyn-1.35.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A omnisharp-roslyn https://github.com/r-ryantm/nixpkgs/archive/69756add0d1c881f1b55377bbbf8d651616908b5.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/hl897zmcr3ykkq5ghp1wggnira3k7vi7-omnisharp-roslyn-1.35.1
ls -la /nix/store/hl897zmcr3ykkq5ghp1wggnira3k7vi7-omnisharp-roslyn-1.35.1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

1 package built:
- omnisharp-roslyn

Maintainer pings

cc @tesq0 for testing.

@FelschR
Copy link
Contributor

FelschR commented May 21, 2020

Have been running this since yesterday. Works as expected.

@nixos-discourse
Copy link

nixos-discourse commented May 21, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/163

@nixos-discourse
Copy link

nixos-discourse commented May 21, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/159

@AndersonTorres
Copy link
Member

AndersonTorres commented May 21, 2020

@FelschR it lacks meta.homepage attribute. After this, I can merge :)

@markuskowa
Copy link
Member

markuskowa commented May 24, 2020

@AndersonTorres only members can add commits to PRs that are not their own.

@markuskowa markuskowa merged commit 2be0555 into NixOS:master May 24, 2020
17 checks passed
17 checks passed
omnisharp-roslyn, omnisharp-roslyn.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0476b97"; rev="0476b979c44edb39815c3e45cdf10f9e4426fc07"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0476b97"; rev="0476b979c44edb39815c3e45cdf10f9e4426fc07"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0476b97"; rev="0476b979c44edb39815c3e45cdf10f9e4426fc07"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0476b97"; rev="0476b979c44edb39815c3e45cdf10f9e4426fc07"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0476b97"; rev="0476b979c44edb39815c3e45cdf10f9e4426fc07"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0476b97"; rev="0476b979c44edb39815c3e45cdf10f9e4426fc07"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0476b97"; rev="0476b979c44edb39815c3e45cdf10f9e4426fc07"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
omnisharp-roslyn, omnisharp-roslyn.passthru.tests on aarch64-linux Success
Details
omnisharp-roslyn, omnisharp-roslyn.passthru.tests on x86_64-linux Success
Details
@r-ryantm r-ryantm deleted the r-ryantm:auto-update/omnisharp-roslyn branch May 24, 2020
@AndersonTorres
Copy link
Member

AndersonTorres commented May 24, 2020

OK, then I will fix it later.

And, seizing the opportunity: @ryantm what about to configure Ryan Bot to post a comment on a thread of Discourse forum - preferably https://discourse.nixos.org/t/prs-ready-for-review-may-2019/?

@markuskowa
Copy link
Member

markuskowa commented May 24, 2020

No worries, I already fixed it. Just made the comment because it seems that very often there seem to be misunderstandings on who is supposed to fix things on an auto update PR. As far as I can tell @FelschR could not have done it here due to lack of permissions.

@ryantm
Copy link
Member

ryantm commented May 28, 2020

@AndersonTorres Do you mean like maybe it would post there after a few days of someone having approved it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.