Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
acme-client: 0.2.5 -> 1.0.1 #88201
Motivation for this change
Initially this pull request was for version 1.0.0, which needed a small patch for a missing include. This has now been fixed upstream in version 1.0.1, and I have updated this pull request accordingly.
The upstream version fails to compile due to a missing limits.h include. I added a patch to fix that. I opened a pull request to upstream it too, but the project has moved from GitHub onto sr.ht and now asks me to send a patch to the mailing list. My default email client is not really suitable for that, and getting git-send-email set up will take some work, so in the meantime it is easier to just patch it here.
I submitted my patch upstream, it was merged, and version 1.0.1 which includes it has been released. So the patch here is no longer necessary. Also, the maintainer added a Nixpkgs-based build environment to the upstream CI setup, so in the future the upstream version will likely not need any patching.
Thanks for the quick release! I updated this pull request.
I did not know about these sources, thanks for the suggestion. That is a nice simplification of the package, I added that to this PR.
@pmahoney, could you please take a look?