Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] openconnect: patch CVE-2020-12105 & CVE-2020-12823 #88208

Open
wants to merge 1 commit into
base: staging-20.03
from

Conversation

@mmilata
Copy link
Member

mmilata commented May 19, 2020

Backport of #88095. Is bumping the version OK as opposed to including the CVE patches?


Also update vpnc script.

Changes: http://www.infradead.org/openconnect/changelog.html

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mmilata mmilata changed the title openconnect: 8.05 -> 8.10 [20.03] openconnect: 8.05 -> 8.10 May 19, 2020
@ofborg ofborg bot requested a review from tricktron May 19, 2020
@tricktron
Copy link
Contributor

tricktron commented Jun 3, 2020

Result of nixpkgs-review pr 88208 1

6 packages marked as broken and skipped:
- connman_dmenu
- gnome3.nautilus-python
- libsForQt5.alkimia
- libsForQt512.alkimia
- networkmanager_dmenu
- strongswanNM
2 packages built:
- openconnect (openconnect_gnutls)
- openconnect_openssl
@worldofpeace
Copy link
Member

worldofpeace commented Jun 18, 2020

Backport of #88095. Is bumping the version OK as opposed to including the CVE patches?

This depends, sometimes the new versions will be bugfixes and features and won't be backwards compatible. In a general sense, whatever is the smallest change surface feasible is likely to have the least amount of side effects because it's more testable and audit-able.

@mmilata mmilata force-pushed the mmilata:20.03/openconnect-8.10 branch from fabbd2c to 58f5c23 Jul 10, 2020
@mmilata
Copy link
Member Author

mmilata commented Jul 10, 2020

Changed the PR to openconnect-8.05 + patches for CVE-2020-12105 and CVE-2020-12823.

IIUC CVE-2019-16239 is already fixed in 8.05 and I mentioned it by mistake.

@mmilata mmilata changed the title [20.03] openconnect: 8.05 -> 8.10 [20.03] openconnect: patch CVE-2020-12105 & CVE-2020-12823 Jul 10, 2020
@ofborg ofborg bot requested a review from tricktron Jul 10, 2020
@tricktron
Copy link
Contributor

tricktron commented Jul 11, 2020

Result of nixpkgs-review pr 88208 1

6 packages marked as broken and skipped:
- connman_dmenu
- gnome3.nautilus-python
- libsForQt5.alkimia
- libsForQt512.alkimia
- networkmanager_dmenu
- strongswanNM
2 packages built:
- openconnect (openconnect_gnutls)
- openconnect_openssl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.