Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minecraft: 2.1.13509 -> 2.1.14947 #88218

Merged
merged 3 commits into from May 30, 2020

Conversation

@piperswe
Copy link
Contributor

piperswe commented May 20, 2020

Motivation for this change

Update Minecraft launcher

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Infinisil
Copy link
Member

Infinisil commented May 20, 2020

Doesn't run, seems to fail to find libuuid:

$ result/bin/minecraft-launcher
$ strace -e trace=file result/bin/minecraft-launcher
[...]
openat(AT_FDCWD, "/nix/store/m7chc42b0mjndgmy5jsd4l2kgfhqpp67-libX11-1.6.8/lib/libuuid.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/nwsn18fysga1n5s0bj4jp4wfwvlbx8b1-glibc-2.30/lib/libuuid.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
+++ exited with 255 +++
@piperswe piperswe changed the title minecraft: 2.1.13509 -> 2.1.14403 minecraft: 2.1.13509 -> 2.1.14947 May 30, 2020
@piperswe
Copy link
Contributor Author

piperswe commented May 30, 2020

Doesn't run, seems to fail to find libuuid:

Thanks for pointing that out - tested and runs now.

@piperswe piperswe force-pushed the piperswe:piperswe/update-minecraft-launcher branch from 32bf301 to b4fa957 May 30, 2020
@piperswe piperswe mentioned this pull request May 30, 2020
4 of 10 tasks complete
@Infinisil Infinisil merged commit edf2e9f into NixOS:master May 30, 2020
16 checks passed
16 checks passed
minecraft, minecraft.passthru.tests on aarch64-linux No attempt
Details
minecraft, minecraft.passthru.tests on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b4fa957"; rev="b4fa9575afb6f98ae38a5674f577d2ecce9cefd6"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b4fa957"; rev="b4fa9575afb6f98ae38a5674f577d2ecce9cefd6"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b4fa957"; rev="b4fa9575afb6f98ae38a5674f577d2ecce9cefd6"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b4fa957"; rev="b4fa9575afb6f98ae38a5674f577d2ecce9cefd6"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b4fa957"; rev="b4fa9575afb6f98ae38a5674f577d2ecce9cefd6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b4fa957"; rev="b4fa9575afb6f98ae38a5674f577d2ecce9cefd6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b4fa957"; rev="b4fa9575afb6f98ae38a5674f577d2ecce9cefd6"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.