Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.editorconfig: fix invalid value for diffs/patches #88239

Merged
merged 1 commit into from May 20, 2020
Merged

Conversation

@zowoq
Copy link
Contributor

zowoq commented May 20, 2020

#87919

Despite being a fairly common pattern in .editorconfig files and being accepted by some editors/linters, it seems ignore is not a valid value.

unset is what is listed in the specification.

https://editorconfig-specification.readthedocs.io/en/latest/#supported-pairs

cc @Mic92

@Mic92 Mic92 merged commit ec3b49c into NixOS:master May 20, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ae876f0"; rev="ae876f032d9ee906d8632d959e10af76d4a5bde2"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ae876f0"; rev="ae876f032d9ee906d8632d959e10af76d4a5bde2"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ae876f0"; rev="ae876f032d9ee906d8632d959e10af76d4a5bde2"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ae876f0"; rev="ae876f032d9ee906d8632d959e10af76d4a5bde2"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ae876f0"; rev="ae876f032d9ee906d8632d959e10af76d4a5bde2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ae876f0"; rev="ae876f032d9ee906d8632d959e10af76d4a5bde2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ae876f0"; rev="ae876f032d9ee906d8632d959e10af76d4a5bde2"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@zowoq zowoq deleted the zowoq:editorconfig branch May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.