Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel-watcher: 0.13.0 -> 0.13.1 #88244

Merged
merged 1 commit into from Jun 4, 2020
Merged

Conversation

@marsam
Copy link
Contributor

marsam commented May 20, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@marsam marsam force-pushed the marsam:update-bazel-watcher branch from 6f89d34 to 1120b5e May 20, 2020
@kalbasit
Copy link
Member

kalbasit commented May 20, 2020

It's failing on Darwin on ofborg. I'll test on my machine and let you know if I see the same behavior.

@marsam
Copy link
Contributor Author

marsam commented May 20, 2020

I can reproduce locally, seems like external/zlib/BUILD.bazel has different permissions on darwin:

$ diffoscope /nix/store/1vdxxpdx2scvawaadvvcjr1nycd3j7fg-bazel-watcher-0.13.1-deps.tar.gz /nix/store/si88z1jhazilpc4f7hfrv99ph2x44cmw-bazel-watcher-0.13.1-deps.tar.gz
--- /nix/store/1vdxxpdx2scvawaadvvcjr1nycd3j7fg-bazel-watcher-0.13.1-deps.tar.gz
+++ /nix/store/si88z1jhazilpc4f7hfrv99ph2x44cmw-bazel-watcher-0.13.1-deps.tar.gz
│   --- 1vdxxpdx2scvawaadvvcjr1nycd3j7fg-bazel-watcher-0.13.1-deps.tar
├── +++ si88z1jhazilpc4f7hfrv99ph2x44cmw-bazel-watcher-0.13.1-deps.tar
│ ├── file list
│ │ @@ -7805,15 +7805,15 @@
│ │  -rwxrwxr-x   0        0        0  5889400 1970-01-01 00:00:01.000000 external/rules_python/tools/piptool.par
│ │  drwxr-xr-x   0        0        0        0 1970-01-01 00:00:01.000000 external/rules_python/tools/update_tools/
│ │  -rw-rw-r--   0        0        0     1758 1970-01-01 00:00:01.000000 external/rules_python/tools/update_tools/Dockerfile
│ │  -rwxrwxr-x   0        0        0  1396310 1970-01-01 00:00:01.000000 external/rules_python/tools/whltool.par
│ │  -rwxrwxr-x   0        0        0      755 1970-01-01 00:00:01.000000 external/rules_python/update_docs.sh
│ │  -rwxrwxr-x   0        0        0     1136 1970-01-01 00:00:01.000000 external/rules_python/update_tools.sh
│ │  drwxr-xr-x   0        0        0        0 1970-01-01 00:00:01.000000 external/zlib/
│ │ -lrwxrwxrwx   0        0        0        0 1970-01-01 00:00:01.000000 external/zlib/BUILD.bazel -> NIX_BUILD_TOP/output/external/com_google_protobuf/third_party/zlib.BUILD
│ │ +lrwxr-xr-x   0        0        0        0 1970-01-01 00:00:01.000000 external/zlib/BUILD.bazel -> NIX_BUILD_TOP/output/external/com_google_protobuf/third_party/zlib.BUILD
│ │  -rw-r--r--   0        0        0     8099 1970-01-01 00:00:01.000000 external/zlib/CMakeLists.txt
│ │  -rw-r--r--   0        0        0    78553 1970-01-01 00:00:01.000000 external/zlib/ChangeLog
│ │  -rw-r--r--   0        0        0    16573 1970-01-01 00:00:01.000000 external/zlib/FAQ
│ │  -rw-r--r--   0        0        0     1988 1970-01-01 00:00:01.000000 external/zlib/INDEX
│ │  -rw-r--r--   0        0        0      100 1970-01-01 00:00:01.000000 external/zlib/Makefile
│ │  -rw-r--r--   0        0        0    13680 1970-01-01 00:00:01.000000 external/zlib/Makefile.in
│ │  -rw-r--r--   0        0        0     5187 1970-01-01 00:00:01.000000 external/zlib/README

I'll try to fix it later

@avdv
Copy link
Contributor

avdv commented May 29, 2020

Hi @marsam,

since bazel is bazel_3 now (#87726), you need to replace the sha256 for fetchAttrs with 1wivfpqa60bxsxqaw6yd5rprf3r820r94rk1wz7jrz1y593zia9s now.

@marsam marsam force-pushed the marsam:update-bazel-watcher branch 2 times, most recently from 005b41f to b7a8c4d May 29, 2020
@marsam marsam merged commit 9831c7a into NixOS:master Jun 4, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
bazel-watcher, bazel-watcher.passthru.tests on aarch64-linux Success
Details
bazel-watcher, bazel-watcher.passthru.tests on x86_64-darwin Success
Details
bazel-watcher, bazel-watcher.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b7a8c4d"; rev="b7a8c4d8574a9295c530b7889493a629fd7f9804"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b7a8c4d"; rev="b7a8c4d8574a9295c530b7889493a629fd7f9804"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b7a8c4d"; rev="b7a8c4d8574a9295c530b7889493a629fd7f9804"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b7a8c4d"; rev="b7a8c4d8574a9295c530b7889493a629fd7f9804"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b7a8c4d"; rev="b7a8c4d8574a9295c530b7889493a629fd7f9804"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b7a8c4d"; rev="b7a8c4d8574a9295c530b7889493a629fd7f9804"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b7a8c4d"; rev="b7a8c4d8574a9295c530b7889493a629fd7f9804"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@marsam marsam deleted the marsam:update-bazel-watcher branch Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.