Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dex2jar: init at 2.0 #88425

Merged
merged 1 commit into from May 28, 2020
Merged

dex2jar: init at 2.0 #88425

merged 1 commit into from May 28, 2020

Conversation

@makefu
Copy link
Contributor

makefu commented May 20, 2020

Motivation for this change

Add dex2jar from my local NUR to nixpkgs. dex2jar is a tool requested in #81418

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@makefu makefu force-pushed the makefu:pkgs/dex2jar/init branch from 5b5b06c to 60d1f13 May 20, 2020
@makefu
Copy link
Contributor Author

makefu commented May 20, 2020

@GrahamcOfBorg build dex2jar

@makefu makefu force-pushed the makefu:pkgs/dex2jar/init branch from 60d1f13 to e682df2 May 28, 2020
@makefu
Copy link
Contributor Author

makefu commented May 28, 2020

thanks for the review!

@Mic92
Copy link
Contributor

Mic92 commented May 28, 2020

Result of nixpkgs-review pr 88425 1

1 package built:
- dex2jar
@Mic92 Mic92 merged commit 1b81b55 into NixOS:master May 28, 2020
17 checks passed
17 checks passed
dex2jar, dex2jar.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
dex2jar, dex2jar.passthru.tests on aarch64-linux Success
Details
dex2jar, dex2jar.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e682df2"; rev="e682df2ef03834beab221fd3782c78a32175cff8"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e682df2"; rev="e682df2ef03834beab221fd3782c78a32175cff8"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e682df2"; rev="e682df2ef03834beab221fd3782c78a32175cff8"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e682df2"; rev="e682df2ef03834beab221fd3782c78a32175cff8"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e682df2"; rev="e682df2ef03834beab221fd3782c78a32175cff8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e682df2"; rev="e682df2ef03834beab221fd3782c78a32175cff8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e682df2"; rev="e682df2ef03834beab221fd3782c78a32175cff8"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.