Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmark broken package: dhall-lsp-server #88426

Conversation

@gvolpe
Copy link
Contributor

gvolpe commented May 20, 2020

Motivation for this change

The package is marked as broken on master.

Things done

I removed the package from the list of broken packages and added an override to not check the failing test suite. I guess it's a fairly trivial change but this is the first time I do it, so please let me know if something is wrong.

I verified it works by running the following command:

$ nix-build --no-out-link -A haskellPackages.dhall-lsp-server
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@gvolpe gvolpe requested a review from cdepillabout as a code owner May 20, 2020
@gvolpe
Copy link
Contributor Author

gvolpe commented May 20, 2020

I'd appreciate if someone would explain the error in the checks:

nix-env failed:
warning: ignoring the user-specified setting 'restrict-eval', because it is a restricted setting and you are not a trusted user
error: while evaluating anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/.gc-of-borg-outpaths.nix:44:12, called from undefined position:
while evaluating anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/pkgs/top-level/release-lib.nix:121:6, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/lib/attrsets.nix:292:43:
while evaluating 'hydraJob' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/lib/customisation.nix:171:14, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/pkgs/top-level/release-lib.nix:121:14:
while evaluating the attribute 'drvPath' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/lib/customisation.nix:188:13:
while evaluating the attribute 'drvPath' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/lib/customisation.nix:155:13:
while evaluating the attribute 'buildInputs' of the derivation 'blake2-0.3.0' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/pkgs/development/haskell-modules/generic-builder.nix:289:3:
while evaluating the attribute 'propagatedBuildInputs' of the derivation 'hlint-3.1.1' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/pkgs/development/haskell-modules/generic-builder.nix:289:3:
while evaluating 'getOutput' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/lib/attrsets.nix:464:23, called from undefined position:
while evaluating anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/pkgs/stdenv/generic/make-derivation.nix:157:17, called from undefined position:
attribute 'ghc-lib-parser_8_10_1_20200412' missing, at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/packet-spot-eval-3/pkgs/development/haskell-modules/configuration-common.nix:1510:22
@gvolpe gvolpe force-pushed the gvolpe:unmark-broken-package/dhall-lsp-server branch from 60e0ddb to 455cb27 May 20, 2020
@cdepillabout
Copy link
Member

cdepillabout commented May 22, 2020

Thanks for sending this PR!

Once you remove the change in hackage-packages.nix, I'll happily merge this in.

@gvolpe gvolpe force-pushed the gvolpe:unmark-broken-package/dhall-lsp-server branch from 455cb27 to f8624e6 May 22, 2020
@gvolpe
Copy link
Contributor Author

gvolpe commented May 22, 2020

Done @cdepillabout , thanks for your help!

@cdepillabout
Copy link
Member

cdepillabout commented May 23, 2020

Thanks for updating this!

@cdepillabout cdepillabout merged commit e4a0aef into NixOS:haskell-updates May 23, 2020
1 check failed
1 check failed
grahamcofborg-eval The branch this PR will merge in to does not cleanly evaluate, and so this PR cannot be checked.
Details
@gvolpe gvolpe deleted the gvolpe:unmark-broken-package/dhall-lsp-server branch May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.