Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systembus-notify: init at 1.0 #88441

Merged
merged 2 commits into from May 24, 2020
Merged

systembus-notify: init at 1.0 #88441

merged 2 commits into from May 24, 2020

Conversation

@oxalica
Copy link
Contributor

oxalica commented May 20, 2020

Motivation for this change

Add a new package systembus-notify which works with earlyoom for desktop notifications.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • 35.7 MiB
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
installPhase = ''
runHook preInstall
install -Dm755 systembus-notify -t $out/bin
install -Dm644 systembus-notify.desktop -t $out/share/applications

This comment has been minimized.

Copy link
@matthewbauer

matthewbauer May 22, 2020

Member

This should go in $out/etc/xdg/autostart/

This comment has been minimized.

Copy link
@oxalica

oxalica May 23, 2020

Author Contributor

If so, is there any way to disable it manually?
And I'm not sure whether $out/etc/xdg/autostart will work for user installation through nix-env -i.

This comment has been minimized.

Copy link
@matthewbauer

matthewbauer May 23, 2020

Member

nix-env should work provided you have $HOME/.nix-profile/etc/xdg in XDG_CONFIG_DIRS. It's pretty standard for apps to do this (see /run/current-system/sw/etc/xdg/autostart for some examples). This also matches what is in the install rule of the Makefile (although it references $HOME).

@oxalica oxalica requested a review from matthewbauer May 24, 2020
@matthewbauer matthewbauer merged commit b53605a into NixOS:master May 24, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="360aa79"; rev="360aa799618ece2f89367eb3089e4c285ff80e6c"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="360aa79"; rev="360aa799618ece2f89367eb3089e4c285ff80e6c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="360aa79"; rev="360aa799618ece2f89367eb3089e4c285ff80e6c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="360aa79"; rev="360aa799618ece2f89367eb3089e4c285ff80e6c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="360aa79"; rev="360aa799618ece2f89367eb3089e4c285ff80e6c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="360aa79"; rev="360aa799618ece2f89367eb3089e4c285ff80e6c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="360aa79"; rev="360aa799618ece2f89367eb3089e4c285ff80e6c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
systembus-notify, systembus-notify.passthru.tests on aarch64-linux Success
Details
systembus-notify, systembus-notify.passthru.tests on x86_64-linux Success
Details
@oxalica oxalica deleted the oxalica:systembus-notify branch May 25, 2020
wchresta added a commit to wchresta/nixpkgs that referenced this pull request May 26, 2020
* systembus-notify: init at 1.0

* systembus-notify: make it autostart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.