Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnucash: Add libdbiDrivers env var to wrapper #88442

Merged
merged 1 commit into from Jun 11, 2020

Conversation

@jasom
Copy link
Contributor

jasom commented May 20, 2020

Motivation for this change

The GNU Cash package clearly wants to be able to use the libdbi
backends, since it pulls them in as dependencies. However, you can only
open xml formatted GNU cash files.

The CMake scripts hard-code the DBD path to be basically
<PATH_OF_LIBDBI>/dbd. However GNU Cash does check the environment
variable GNC_DBD_DIR, so I set that environment variable in the wrapper
script.

With this change, you should be able to e.g. "Save As" in the sqlite
format.

Fixes issue #57445

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) not sure why, but it increased the closure size by 17MB
  • Ensured that relevant documentation is up to date No doc changes needed
  • Fits CONTRIBUTING.md.
The GNU Cash package clearly *wants* to be able to use the libdbi
backends, since it pulls them in as dependencies.  However, you can only
open xml formatted GNU cash files.

The CMake scripts hard-code the DVD path to be basically
<PATH_OF_LIBDBI>/dbd.  However GNU Cash does check the environment
variable GNC_DBD_DIR, so I set that environment variable in the wrapper
script.

With this change, you should be able to e.g. "Save As" in the sqlite
format.

Fixes issue #57445
@jasom jasom force-pushed the jasom:gnucash-dbd-location-fix branch from 134f561 to 93d4bf5 May 20, 2020
@ofborg ofborg bot requested review from domenkozar and peti May 20, 2020
Copy link
Contributor

bjornfor left a comment

Nice!

@bjornfor bjornfor merged commit afb5de4 into NixOS:master Jun 11, 2020
17 checks passed
17 checks passed
editorconfig editorconfig
Details
Evaluation Performance Report Evaluator Performance Report
Details
gnucash, gnucash.passthru.tests on aarch64-linux Success
Details
gnucash, gnucash.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93d4bf5"; rev="93d4bf5406535c396d1c8adb9ea4176babb80a63"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93d4bf5"; rev="93d4bf5406535c396d1c8adb9ea4176babb80a63"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93d4bf5"; rev="93d4bf5406535c396d1c8adb9ea4176babb80a63"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93d4bf5"; rev="93d4bf5406535c396d1c8adb9ea4176babb80a63"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93d4bf5"; rev="93d4bf5406535c396d1c8adb9ea4176babb80a63"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93d4bf5"; rev="93d4bf5406535c396d1c8adb9ea4176babb80a63"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93d4bf5"; rev="93d4bf5406535c396d1c8adb9ea4176babb80a63"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.