Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

earlyoom: patch absolute dbus path and make nixos module up to date #88443

Merged
merged 3 commits into from May 25, 2020

Conversation

@oxalica
Copy link
Contributor

oxalica commented May 20, 2020

Motivation for this change

earlyoom v1.6 replaces old notification logic with dbus-send / systembus-notify. (See Changelog.)
But dbus path is not patched and options of nixos/earlyoom is not up to date.

Related: #88441

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • Not changed.
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
description = ''
Send notifications about killed processes via the system d-bus.
To actually see the notifications in your GUI session, you need to have
<literal>systembus-notify</literal> running as your user.

This comment has been minimized.

Copy link
@matthewbauer

matthewbauer May 20, 2020

Member

Maybe we should package this? Opened rfjakob/systembus-notify#3 for a user service

This comment has been minimized.

Copy link
@oxalica

oxalica May 22, 2020

Author Contributor

See #88441. But is there any way to setup a systemd user service in system configuration?

This comment has been minimized.

Copy link
@matthewbauer

matthewbauer May 22, 2020

Member

It sounds like the autostart desktop file is enough

This comment has been minimized.

Copy link
@matthewbauer

matthewbauer May 22, 2020

Member

(but yes there is, through systemd.user.services I think)

This comment has been minimized.

Copy link
@oxalica

oxalica May 24, 2020

Author Contributor

Should I make environment.systemPackages = [ pkgs.systembus-notify ]; when notification is enabled? But this requires #88441 to be merged first.

This comment has been minimized.

Copy link
@matthewbauer

matthewbauer May 24, 2020

Member

Yeah - let’s do that and merge systembus-notify first

oxalica added 3 commits May 19, 2020
@oxalica oxalica force-pushed the oxalica:fix/earlyoom branch from 0b0c618 to 5742bde May 25, 2020
@oxalica oxalica requested a review from matthewbauer May 25, 2020
@matthewbauer matthewbauer merged commit fe3e52c into NixOS:master May 25, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
earlyoom, earlyoom.passthru.tests on aarch64-linux Success
Details
earlyoom, earlyoom.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5742bde"; rev="5742bdeb6aca9f90b03f653ec41b002c8904a0dd"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5742bde"; rev="5742bdeb6aca9f90b03f653ec41b002c8904a0dd"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5742bde"; rev="5742bdeb6aca9f90b03f653ec41b002c8904a0dd"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5742bde"; rev="5742bdeb6aca9f90b03f653ec41b002c8904a0dd"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5742bde"; rev="5742bdeb6aca9f90b03f653ec41b002c8904a0dd"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5742bde"; rev="5742bdeb6aca9f90b03f653ec41b002c8904a0dd"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5742bde"; rev="5742bdeb6aca9f90b03f653ec41b002c8904a0dd"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@oxalica oxalica deleted the oxalica:fix/earlyoom branch May 25, 2020
wchresta added a commit to wchresta/nixpkgs that referenced this pull request May 26, 2020
…ixOS#88443)

* earlyoom: patch absolute path of dbus-send

* nixos/earlyoom: replace `notificationsCommand` with `enableNotification`

* nixos/earlyoom: setup `systembus-notify` when `enableNotification`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.