Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.mirage-crypto 0.6.2 → 0.7.0 and updated/new dependencies #88467

Merged
merged 8 commits into from May 21, 2020

Conversation

@sternenseemann
Copy link
Member

sternenseemann commented May 20, 2020

Motivation for this change

New mirage-crypto release.

Things done
  • Removed cpuAcceleration argument of mirage-crypto (now acceleration support is checked at runtime and the compile time switch has been removed as it is obsolete now)
  • Packaged new dependency mirage-unix and the new packages it requires:
    • io-page-unix (also updated io-page)
    • mirage-runtime (added in mirage-subfolder in case we want to package the other packages of that repository)
    • functoria-runtime (also updated functoria)
  • Updated eqaf, since build fails with 0.6 (0.7 also introduces tests which require crowbar, I'll work on packaging crowbar in the near future)

Sorry for the big PR, unfortunately more or less required due to the big changes in the release.

cc @vbgl

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@sternenseemann
Copy link
Member Author

sternenseemann commented May 20, 2020

@GrahamcOfBorg build jackline ocamlPackages.irmin-unix

@vbgl
vbgl approved these changes May 21, 2020
pkgs/development/ocaml-modules/io-page/unix.nix Outdated Show resolved Hide resolved
@sternenseemann sternenseemann force-pushed the sternenseemann:mirage-crypto-0.7.0 branch from b5ce4b6 to f8121c1 May 21, 2020
@vbgl
Copy link
Contributor

vbgl commented May 21, 2020

@GrahamcOfBorg build ocamlPackages.mirage-crypto-pk

@vbgl vbgl merged commit 2d51940 into NixOS:master May 21, 2020
18 checks passed
18 checks passed
editorconfig editorconfig
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8121c1"; rev="f8121c17cf3314dc6a6c36e650eaca5841730b9f"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8121c1"; rev="f8121c17cf3314dc6a6c36e650eaca5841730b9f"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8121c1"; rev="f8121c17cf3314dc6a6c36e650eaca5841730b9f"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8121c1"; rev="f8121c17cf3314dc6a6c36e650eaca5841730b9f"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8121c1"; rev="f8121c17cf3314dc6a6c36e650eaca5841730b9f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8121c1"; rev="f8121c17cf3314dc6a6c36e650eaca5841730b9f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8121c1"; rev="f8121c17cf3314dc6a6c36e650eaca5841730b9f"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ocamlPackages.mirage-crypto-pk on aarch64-linux Success
Details
ocamlPackages.mirage-crypto-pk on x86_64-darwin Success
Details
ocamlPackages.mirage-crypto-pk on x86_64-linux Success
Details
@sternenseemann sternenseemann deleted the sternenseemann:mirage-crypto-0.7.0 branch May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.