Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rivet: 2.7.2 -> 3.1.1 #88476

Merged
merged 4 commits into from May 26, 2020
Merged

rivet: 2.7.2 -> 3.1.1 #88476

merged 4 commits into from May 26, 2020

Conversation

@veprbl
Copy link
Member

veprbl commented May 21, 2020

Motivation for this change

Update Rivet to the latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@veprbl veprbl force-pushed the veprbl:pr/rivet3 branch from 9fa08a6 to 8b4c4e8 May 21, 2020
@veprbl veprbl requested review from FRidh and jonringer as code owners May 21, 2020
@veprbl veprbl changed the title rivet: 2.7.2 -> 3.1.1 WIP rivet: 2.7.2 -> 3.1.1 May 21, 2020
@veprbl veprbl force-pushed the veprbl:pr/rivet3 branch from 8b4c4e8 to d6972cd May 23, 2020
@veprbl veprbl force-pushed the veprbl:pr/rivet3 branch 2 times, most recently from b9ac198 to 4229bac May 23, 2020
@veprbl veprbl changed the title WIP rivet: 2.7.2 -> 3.1.1 rivet: 2.7.2 -> 3.1.1 May 23, 2020
veprbl added 2 commits Nov 18, 2019
@veprbl veprbl force-pushed the veprbl:pr/rivet3 branch from 4229bac to 475d5df May 25, 2020
@veprbl veprbl merged commit 5035c65 into NixOS:master May 26, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="475d5df"; rev="475d5df12a19e8de4bc99a49bef81e37d7a57a34"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="475d5df"; rev="475d5df12a19e8de4bc99a49bef81e37d7a57a34"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="475d5df"; rev="475d5df12a19e8de4bc99a49bef81e37d7a57a34"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="475d5df"; rev="475d5df12a19e8de4bc99a49bef81e37d7a57a34"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="475d5df"; rev="475d5df12a19e8de4bc99a49bef81e37d7a57a34"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="475d5df"; rev="475d5df12a19e8de4bc99a49bef81e37d7a57a34"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="475d5df"; rev="475d5df12a19e8de4bc99a49bef81e37d7a57a34"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
rivet, rivet.passthru.tests, yoda, yoda.passthru.tests on aarch64-linux Success
Details
rivet, rivet.passthru.tests, yoda, yoda.passthru.tests on x86_64-darwin Success
Details
rivet, rivet.passthru.tests, yoda, yoda.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.