Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.stack-data: init at 0.0.7 #88494

Open
wants to merge 4 commits into
base: master
from

Conversation

@jluttine
Copy link
Member

jluttine commented May 21, 2020

Motivation for this change

Add Python package stack-data and its dependencies.

IPython will soon need this dependency: https://github.com/ipython/ipython/blob/master/setup.py#L194 (permalink https://github.com/ipython/ipython/blob/a483781c6e480b18b6cdc78a9851c23cd528a890/setup.py#L194), so with this PR stack-data would be readily available in nixpkgs when IPython release will depend on stack-data. I needed to add this to nixpkgs already now because I was using master branch of IPython locally. So I thought I'd provide a PR for these upcoming dependencies.

I'll run nixpkgs-review soon.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jluttine jluttine requested review from FRidh and jonringer as code owners May 21, 2020
@jluttine
Copy link
Member Author

jluttine commented May 21, 2020

nixpkgs-review passed

jluttine added 3 commits May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.