Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] pythonPackages.fritzconnection: 0.8.4 -> 1.2.1 #88501

Merged
merged 2 commits into from May 22, 2020

Conversation

@jokogr
Copy link
Contributor

jokogr commented May 21, 2020

Motivation for this change

Backport #83451 to 20.03. There were a couple of conflicts that were easily solved.

The compiled package seems to be working, I've run the code mentioned in the official documentation:

$ python test.py
FRITZ!Box 7530 at http://192.168.178.1
FRITZ!OS: 7.14
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jokogr jokogr requested review from FRidh and jonringer as code owners May 21, 2020
@jokogr jokogr changed the title pythonPackages.fritzconnection: 0.8.4 -> 1.2.1 [20.03] pythonPackages.fritzconnection: 0.8.4 -> 1.2.1 May 21, 2020
@ofborg ofborg bot added the 6.topic: python label May 21, 2020
@Valodim
Copy link
Contributor

Valodim commented May 21, 2020

seems my maintainer entry isn't yet in 20.03. my first PR was merged Feb14, seems I barely missed it ;) You can include 52ac65c in this PR to backport it.

lgtm otherwise 👍

@jokogr jokogr force-pushed the jokogr:u/fritzconnection-1.2.1-20.03 branch from 1439bf3 to 0edf164 May 21, 2020
@ofborg ofborg bot added the 8.has: clean-up label May 21, 2020
@ofborg ofborg bot requested review from dotlambda and Valodim May 21, 2020
@jokogr jokogr merged commit 48723f4 into NixOS:release-20.03 May 22, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0edf164"; rev="0edf164f940beb0bd90219c6db4c3211929617c9"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0edf164"; rev="0edf164f940beb0bd90219c6db4c3211929617c9"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0edf164"; rev="0edf164f940beb0bd90219c6db4c3211929617c9"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0edf164"; rev="0edf164f940beb0bd90219c6db4c3211929617c9"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0edf164"; rev="0edf164f940beb0bd90219c6db4c3211929617c9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0edf164"; rev="0edf164f940beb0bd90219c6db4c3211929617c9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0edf164"; rev="0edf164f940beb0bd90219c6db4c3211929617c9"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jokogr jokogr deleted the jokogr:u/fritzconnection-1.2.1-20.03 branch May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.