Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fwupd: 1.4.1 -> 1.4.2 #88506

Merged
merged 1 commit into from May 27, 2020
Merged

fwupd: 1.4.1 -> 1.4.2 #88506

merged 1 commit into from May 27, 2020

Conversation

@r-ryantm
Copy link
Contributor

r-ryantm commented May 21, 2020

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/fwupd/versions.

meta.description for fwupd is: ""

meta.homepage for fwupd is: "https://fwupd.org/"

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
15 total rebuild path(s)

6 package rebuild(s)

6 x86_64-linux rebuild(s)
5 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
discover
fwupd
gnome-firmware-updater
gnome3.gnome-software
plasma5.discover
tests.nixos-functions.nixos-test
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/2hs2n330nwfmpscl1f6v591dsgffg1b0-fwupd-1.4.2 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A fwupd https://github.com/r-ryantm/nixpkgs/archive/9dcffdecb654621a6b5978de33577a5bc6291209.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/2hs2n330nwfmpscl1f6v591dsgffg1b0-fwupd-1.4.2
ls -la /nix/store/2hs2n330nwfmpscl1f6v591dsgffg1b0-fwupd-1.4.2/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

4 packages built:
- discover
- fwupd
- gnome-firmware-updater
- gnome3.gnome-software

Maintainer pings

cc @jtojnar for testing.

@mweinelt
Copy link
Member

mweinelt commented May 21, 2020

# fwupdmgr --version
client version:	1.4.2
compile-time dependency versions
	gusb:	0.3.3
	efivar:	37
daemon version:	1.4.2
# fwupdmgr refresh --force
Fetching signature https://cdn.fwupd.org/downloads/firmware.xml.gz.jcat
Downloading…             [***************************************]
Fetching metadata https://cdn.fwupd.org/downloads/firmware-00543-stable.xml.gz
Downloading…             [***************************************]
Successfully downloaded new metadata: 5 local devices supported
# fwupdmgr update
• Thunderbolt Controller has the latest available firmware version
• Embedded Controller has the latest available firmware version
Upgrade available for Intel Management Engine from 184.70.3626 to 184.77.3664
20KH006MGE must remain plugged into a power source for the duration of the update to avoid damage. Continue with update? [Y|n]: y
Downloading 184.77.3664 for Intel Management Engine...
Fetching firmware https://fwupd.org/downloads/e7bb27e5d997e02b3516e61477563fa1b1a1af47fb7d3129568ca37989082c1d-Lenovo-ThinkPad-X1Carbon6th-ConsumerMEFirmware-11.8.77.3664.cab
Downloading…             [***************************************]
Decompressing…           [***************************************]
Authenticating…          [***************************************]
Updating Intel Management Engine…                                ]
Scheduling…              [***************************************]
Successfully installed firmware
• SAMSUNG MZVLB1T0HALR-000L7 has the latest available firmware version
Upgrade available for System Firmware from 0.1.46 to 0.1.48
20KH006MGE must remain plugged into a power source for the duration of the update to avoid damage. Continue with update? [Y|n]: y

It adds the capsules, then boots into the normal system, where fwupd tells me to apply the very same updates again.

Seems to be https://github.com/fwupd/fwupd/issues/2118.

Copy link
Contributor

jonringer left a comment

diff LGTM

https://github.com/NixOS/nixpkgs/pull/88506
1 package blacklisted:
tests.nixos-functions.nixos-test

4 packages built:
discover fwupd gnome-firmware-updater gnome3.gnome-software

I'll let someone else test

@jtojnar
Copy link
Contributor

jtojnar commented May 27, 2020

@mweinelt is that a regression?

@mweinelt
Copy link
Member

mweinelt commented May 27, 2020

@mweinelt is that a regression?

It's not working on 1.4.1 either, so IMO go ahead.

@jtojnar jtojnar merged commit 1995203 into NixOS:master May 27, 2020
18 checks passed
18 checks passed
editorconfig editorconfig
Details
fwupd, fwupd.passthru.tests on aarch64-linux Timed out, unknown build status
Details
fwupd, fwupd.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
fwupd, fwupd.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9dcffde"; rev="9dcffdecb654621a6b5978de33577a5bc6291209"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9dcffde"; rev="9dcffdecb654621a6b5978de33577a5bc6291209"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9dcffde"; rev="9dcffdecb654621a6b5978de33577a5bc6291209"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9dcffde"; rev="9dcffdecb654621a6b5978de33577a5bc6291209"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9dcffde"; rev="9dcffdecb654621a6b5978de33577a5bc6291209"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9dcffde"; rev="9dcffdecb654621a6b5978de33577a5bc6291209"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9dcffde"; rev="9dcffdecb654621a6b5978de33577a5bc6291209"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@mweinelt
Copy link
Member

mweinelt commented May 27, 2020

Upgrades used to work on 1.4.1, so I assume it's a regression in the capsule then.

#87017 (comment)

@r-ryantm r-ryantm deleted the r-ryantm:auto-update/fwupd branch May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.