Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zbar: 0.23 -> 0.23.1 #88527

Merged
merged 1 commit into from May 23, 2020
Merged

zbar: 0.23 -> 0.23.1 #88527

merged 1 commit into from May 23, 2020

Conversation

@KoviRobi
Copy link
Contributor

KoviRobi commented May 21, 2020

This allows decoding binary QR codes, e.g as in
https://wiki.archlinux.org/index.php/Paperkey

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@7c6f434c
Copy link
Member

7c6f434c commented May 23, 2020

Hash change without version update, does not work.

@jtojnar
Copy link
Contributor

jtojnar commented May 23, 2020

Changelog looks okay: https://github.com/mchehab/zbar/blob/0.23.1/ChangeLog#L1-L15

We disable python and explicitly set gtk3 so the autodetect changes should not affect us.

This allows decoding binary QR codes, e.g as in
https://wiki.archlinux.org/index.php/Paperkey
@KoviRobi KoviRobi force-pushed the KoviRobi:zbar-0.23.1-update branch from 2b12ec1 to d48ec14 May 23, 2020
@KoviRobi
Copy link
Contributor Author

KoviRobi commented May 23, 2020

Oh that's my bad, but it turns out just hash update does actually work as fetchgit fetches by hash, today I learnt.

@KoviRobi
Copy link
Contributor Author

KoviRobi commented May 23, 2020

I don't have a working webcam on this laptop (no driver, Intel AVStream 2500) but zbarcam-{qt,gtk} at least launch without errors, it's zbarimg that I needed to get updated

@7c6f434c 7c6f434c merged commit 80ab05e into NixOS:master May 23, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d48ec14"; rev="d48ec14f48096af712322d0e5bb72160ef66b300"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d48ec14"; rev="d48ec14f48096af712322d0e5bb72160ef66b300"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d48ec14"; rev="d48ec14f48096af712322d0e5bb72160ef66b300"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d48ec14"; rev="d48ec14f48096af712322d0e5bb72160ef66b300"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d48ec14"; rev="d48ec14f48096af712322d0e5bb72160ef66b300"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d48ec14"; rev="d48ec14f48096af712322d0e5bb72160ef66b300"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d48ec14"; rev="d48ec14f48096af712322d0e5bb72160ef66b300"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
zbar, zbar.passthru.tests on aarch64-linux Success
Details
zbar, zbar.passthru.tests on x86_64-linux Success
Details
@soareschen soareschen mentioned this pull request Jun 1, 2020
2 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.