Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger2beancount: init at 2.1 #88544

Open
wants to merge 1 commit into
base: master
from

Conversation

@Pablo1107
Copy link
Contributor

Pablo1107 commented May 21, 2020

Motivation for this change

This PR adds a package for ledger2beancount, a "
Ledger to Beancount text-based converter"

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@balsoft
Copy link
Member

balsoft commented Jul 2, 2020

Have you tested that the binaries work?

@Pablo1107 Pablo1107 force-pushed the Pablo1107:ledger2beancount-2.1 branch from 9b19ad6 to 5126287 Jul 2, 2020
@balsoft
Copy link
Member

balsoft commented Jul 2, 2020

Do you really need makeWrapper? Also, why is perl in buildInputs and not nativeBuildInputs ?

@Pablo1107
Copy link
Contributor Author

Pablo1107 commented Jul 2, 2020

Do you really need makeWrapper? Also, why is perl in buildInputs and not nativeBuildInputs ?

You're right, I based this on another perl package which include it as a buildInputs and this was before I even knew the difference between nativeBuildInputs and buildInputs.

@balsoft
Copy link
Member

balsoft commented Jul 2, 2020

Wait, you might actually need perl in buildInputs if it's used to set the shebang; After all, it's required to run the script on the host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.