Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copper: init at 4.4 #88545

Merged
merged 1 commit into from Aug 24, 2020
Merged

copper: init at 4.4 #88545

merged 1 commit into from Aug 24, 2020

Conversation

@jacereda
Copy link
Contributor

@jacereda jacereda commented May 21, 2020

Motivation for this change

Copper is used to build code-browser: https://tibleiz.net/code-browser/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Lassulus
Copy link
Contributor

@Lassulus Lassulus commented Aug 22, 2020

needs a rebase

@jacereda jacereda force-pushed the jacereda:copper branch from f8d52d5 to faad135 Aug 23, 2020
@jacereda
Copy link
Contributor Author

@jacereda jacereda commented Aug 23, 2020

needs a rebase

Done.

@jacereda jacereda force-pushed the jacereda:copper branch from faad135 to 86b74b2 Aug 23, 2020
@jacereda jacereda force-pushed the jacereda:copper branch from 86b74b2 to bf9df74 Aug 24, 2020
@Lassulus
Copy link
Contributor

@Lassulus Lassulus commented Aug 24, 2020

running coc or collvm gives me /nix/store/daraq50260yqj003inkgsvyxpfqnf3w6-copper-4.4/bin/coc: line 35: copper-c: command not found. Should this work?

@jacereda
Copy link
Contributor Author

@jacereda jacereda commented Aug 24, 2020

running coc or collvm gives me /nix/store/daraq50260yqj003inkgsvyxpfqnf3w6-copper-4.4/bin/coc: line 35: copper-c: command not found. Should this work?

Those are the scripts for the LLVM and C backends. This package only builds the x64 backend.

@Lassulus
Copy link
Contributor

@Lassulus Lassulus commented Aug 24, 2020

Alright, I guess someone can add them later if they are needed

@Lassulus Lassulus merged commit 4f68ebf into NixOS:master Aug 24, 2020
16 checks passed
16 checks passed
copper, copper.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
copper, copper.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bf9df74"; rev="bf9df7451173f18ecd9b205f379b260b938d8f2c"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bf9df74"; rev="bf9df7451173f18ecd9b205f379b260b938d8f2c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bf9df74"; rev="bf9df7451173f18ecd9b205f379b260b938d8f2c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bf9df74"; rev="bf9df7451173f18ecd9b205f379b260b938d8f2c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bf9df74"; rev="bf9df7451173f18ecd9b205f379b260b938d8f2c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bf9df74"; rev="bf9df7451173f18ecd9b205f379b260b938d8f2c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bf9df74"; rev="bf9df7451173f18ecd9b205f379b260b938d8f2c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jacereda
Copy link
Contributor Author

@jacereda jacereda commented Aug 24, 2020

Thanks. If you want to see it in use: #88548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.