Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] Update Electron 6,7,8 #88550

Merged
merged 3 commits into from Jun 1, 2020
Merged

[20.03] Update Electron 6,7,8 #88550

merged 3 commits into from Jun 1, 2020

Conversation

@prusnak
Copy link
Member

prusnak commented May 21, 2020

Motivation for this change

Backport of #86237 to stable - contains security fixes (9x CVE)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
prusnak added 3 commits Apr 28, 2020
(cherry picked from commit 77cade8)
(cherry picked from commit eee7e5b)
(cherry picked from commit 72aebd3)
@prusnak prusnak mentioned this pull request May 21, 2020
3 of 10 tasks complete
@mmahut mmahut requested review from travisbhartwell and manveru May 24, 2020
@mmahut mmahut merged commit 4a2da01 into NixOS:release-20.03 Jun 1, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
electron_6, electron_6.passthru.tests, electron_7, electron_7.passthru.tests, electron_8, electron_8.passthru.tests on aarch64-linux Success
Details
electron_6, electron_6.passthru.tests, electron_7, electron_7.passthru.tests, electron_8, electron_8.passthru.tests on x86_64-darwin Success
Details
electron_6, electron_6.passthru.tests, electron_7, electron_7.passthru.tests, electron_8, electron_8.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a99bb40"; rev="a99bb404cfc84e2fef3423107c857e036295bf99"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a99bb40"; rev="a99bb404cfc84e2fef3423107c857e036295bf99"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a99bb40"; rev="a99bb404cfc84e2fef3423107c857e036295bf99"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a99bb40"; rev="a99bb404cfc84e2fef3423107c857e036295bf99"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a99bb40"; rev="a99bb404cfc84e2fef3423107c857e036295bf99"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a99bb40"; rev="a99bb404cfc84e2fef3423107c857e036295bf99"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a99bb40"; rev="a99bb404cfc84e2fef3423107c857e036295bf99"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@prusnak prusnak deleted the prusnak:electron-20.03 branch Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.