Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontforge: CVE-2020-5395, CVE-2020-5496 #88557

Closed
wants to merge 2 commits into from

Conversation

@erictapen
Copy link
Contributor

erictapen commented May 21, 2020

Motivation for this change

Close #88291.

Things done

See the commit message for reasoning.

This needs to be backported to nixos-20.03.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

puzzlewolf left a comment

I can't nixpkgs-review this giant rebuild on my laptop, sorry. But you could take the opportunity and replace fetchurl with fetchFromGithub and http with https in meta.homepage. :)

@erictapen erictapen force-pushed the erictapen:fontforge-CVE-2020-5395 branch from 5b4dfbe to 8cfbdaa May 25, 2020
erictapen added 2 commits May 21, 2020
These CVEs have two different issues being tagged as 'Exploit'.

CVE-2020-5395 [0]: fontforge/fontforge#4084
CVE-2020-5496 [1]: fontforge/fontforge#4085

Both issues refer to [2] as a fix, so I guess this patch fixes it.

[0] https://nvd.nist.gov/vuln/detail/CVE-2020-5395
[1] https://nvd.nist.gov/vuln/detail/CVE-2020-5496
[2] fontforge/fontforge@048a91e
The old homepage fontforge.github.io redirects to fontforge.org
@erictapen erictapen force-pushed the erictapen:fontforge-CVE-2020-5395 branch from bcd5a0b to a16ff5e May 25, 2020
@erictapen
Copy link
Contributor Author

erictapen commented May 25, 2020

Fixed the https URL.

We use fetchurl, as we are building from the release tarball, not from source. I'm not satisfied with the situation but it's non-trivial to fix, as the release tarball contains more than just the sources. I'm working on a PR that fixes the issue and upgrades to 20200314.

@puzzlewolf
Copy link
Contributor

puzzlewolf commented May 25, 2020

Ah, that makes sense. I was wondering why you didn't just update 😃

@FRidh
Copy link
Member

FRidh commented May 29, 2020

ofborg failed to fetch the patch

@FRidh FRidh added this to WIP in Staging via automation May 29, 2020
@erictapen
Copy link
Contributor Author

erictapen commented May 30, 2020

That's weird, the URL is still valid. Let's retry it.
@GrahamcOfBorg build fontforge

@erictapen
Copy link
Contributor Author

erictapen commented May 30, 2020

/nix/store/01d4cg8iwh6y0gb7zc0vz84q3spc927y-CVE-2020-5395+CVE-2020-5496.patch.drv definetely builds locally for me. @grahamc do you have an idea?

@FRidh note that the check fontforge on {x86_64-linux,aarch64-linux} resulted in a success.

@FRidh
Copy link
Member

FRidh commented Jun 7, 2020

I've merged #89583.

@FRidh FRidh closed this Jun 7, 2020
Staging automation moved this from WIP to Done Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.