Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg{_4,-full}: 4.2.2 -> 4.2.3, ffmpeg_2_8: 2.8.15 -> 2.8.16 #88561

Merged
merged 3 commits into from May 27, 2020

Conversation

@zowoq
Copy link
Contributor

zowoq commented May 22, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@zowoq zowoq force-pushed the zowoq:ffmpeg branch from e71e062 to cfaa803 May 24, 2020

src = fetchurl {
url = "https://www.ffmpeg.org/releases/ffmpeg-${version}.tar.xz";
sha256 = "176jn1lcdf0gk7sa5l2mv0faqp5dsqdhx1gqcrgymqhfmdal4xfb";
url = "https://www.ffmpeg.org/releases/ffmpeg-${version}.tar.bz2";

This comment has been minimized.

Copy link
@marsam

marsam May 27, 2020

Contributor

just curious, why did you change it to bz2?

This comment has been minimized.

Copy link
@zowoq

zowoq May 27, 2020

Author Contributor

Reusing the hash from ffmpeg_4 which uses bz2.

Not sure why they were using different tarballs, ffmpeg-full was changed to xz in 3a61de4.

@marsam marsam merged commit 6050c0b into NixOS:master May 27, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
ffmpeg-full, ffmpeg-full.passthru.tests, ffmpeg_2_8, ffmpeg_2_8.passthru.tests, ffmpeg_4, ffmpeg_4.passthru.tests on aarch64-linux Success
Details
ffmpeg-full, ffmpeg-full.passthru.tests, ffmpeg_2_8, ffmpeg_2_8.passthru.tests, ffmpeg_4, ffmpeg_4.passthru.tests on x86_64-darwin Success
Details
ffmpeg-full, ffmpeg-full.passthru.tests, ffmpeg_2_8, ffmpeg_2_8.passthru.tests, ffmpeg_4, ffmpeg_4.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cfaa803"; rev="cfaa8035d721dc526d4d719a506de15771add05d"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cfaa803"; rev="cfaa8035d721dc526d4d719a506de15771add05d"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cfaa803"; rev="cfaa8035d721dc526d4d719a506de15771add05d"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cfaa803"; rev="cfaa8035d721dc526d4d719a506de15771add05d"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cfaa803"; rev="cfaa8035d721dc526d4d719a506de15771add05d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cfaa803"; rev="cfaa8035d721dc526d4d719a506de15771add05d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cfaa803"; rev="cfaa8035d721dc526d4d719a506de15771add05d"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@zowoq zowoq deleted the zowoq:ffmpeg branch May 27, 2020
@vcunat vcunat mentioned this pull request May 31, 2020
1 of 1 task complete
@zowoq zowoq mentioned this pull request Jun 8, 2020
2 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.