Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sway-contrib: init with grimshot and inactive-windows-transparency #88577

Merged
merged 2 commits into from Jun 14, 2020

Conversation

@evils
Copy link
Contributor

evils commented May 22, 2020

Motivation for this change

no one appears to be against to the solution reached in #87979

closes #87831

Things done

add package set pkgs.sway-contrib containing
sway-contrib.grimshot, a screenshot utility
with an alias for pkgs.grimshot as this is a fairly fleshed out tool

sway-contrib.inactive-windows-transparency, a script that makes inactive windows transparent

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • /nix/store/ra8b9q1ihdnp04595ahdl6iczg08drgm-grimshot-2020-05-08 101551232
    • /nix/store/hd48r6ss5lpvgqch663z1alnbf6s4p72-python3.7-sway-inactive-windows-transparency-1.4 107722384
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notes

grimshot may get a rotated screen wrong due to bugs in dependencies that have been fixed upstream
inactive-windows-transparency leaves the last active window on a secondary screen active swaywm/sway#5372

Copy link
Member

primeos left a comment

I added a few TODOs.

Regarding #87979 (comment): Yes, unfortunately (in this case) mentioning an issue in a PR doesn't generate any notifications.

pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
pkgs/applications/window-managers/sway/contrib.nix Outdated Show resolved Hide resolved
pkgs/applications/window-managers/sway/contrib.nix Outdated Show resolved Hide resolved
@evils evils force-pushed the evils:sway-contrib branch 4 times, most recently from 601bd14 to 491bd89 Jun 5, 2020
@primeos
primeos approved these changes Jun 7, 2020
Copy link
Member

primeos left a comment

LGTM now and works as expected. @Mic92 feel free to merge if you want. Alternatively I'll merge it tomorrow if no one has any complaints until then.

Copy link
Contributor

Mic92 left a comment

Untested but looks good to me if those last issues are fixed.

@evils evils force-pushed the evils:sway-contrib branch 2 times, most recently from 52a2191 to d904f54 Jun 8, 2020
@evils
Copy link
Contributor Author

evils commented Jun 10, 2020

i think this is ready to merge

@Ma27
Ma27 approved these changes Jun 10, 2020
Copy link
Member

Ma27 left a comment

Thanks! Successfully tested this locally.

I left two minor comments, but those are definitely not supposed to keep this PR from getting merged :)

@evils evils force-pushed the evils:sway-contrib branch from d904f54 to 1db748e Jun 11, 2020
@Ma27 Ma27 merged commit baa980c into NixOS:master Jun 14, 2020
16 checks passed
16 checks passed
sway-contrib.grimshot, sway-contrib.grimshot.passthru.tests, sway-contrib.inactive-windows-transparency, sway-contrib.inactive-windows-transparency.passthru.tests on aarch64-linux Failure
Details
sway-contrib.grimshot, sway-contrib.grimshot.passthru.tests, sway-contrib.inactive-windows-transparency, sway-contrib.inactive-windows-transparency.passthru.tests on x86_64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1db748e"; rev="1db748ef6aa41ec9777a9bf97963d3a4f38866c0"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1db748e"; rev="1db748ef6aa41ec9777a9bf97963d3a4f38866c0"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1db748e"; rev="1db748ef6aa41ec9777a9bf97963d3a4f38866c0"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1db748e"; rev="1db748ef6aa41ec9777a9bf97963d3a4f38866c0"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1db748e"; rev="1db748ef6aa41ec9777a9bf97963d3a4f38866c0"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1db748e"; rev="1db748ef6aa41ec9777a9bf97963d3a4f38866c0"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1db748e"; rev="1db748ef6aa41ec9777a9bf97963d3a4f38866c0"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@evils evils deleted the evils:sway-contrib branch Jun 15, 2020
@primeos primeos mentioned this pull request Jun 15, 2020
15 of 19 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.