Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages: default to OCaml 4.10 #88605

Merged
merged 6 commits into from May 27, 2020
Merged

ocamlPackages: default to OCaml 4.10 #88605

merged 6 commits into from May 27, 2020

Conversation

@vbgl
Copy link
Contributor

vbgl commented May 22, 2020

Motivation for this change

nixpkgs is ready

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
vbgl added 6 commits May 22, 2020
@vbgl
Copy link
Contributor Author

vbgl commented May 23, 2020

@GrahamcOfBorg build flow framac google-drive-ocamlfuse hol_light jackline opam ott vagrant virt-top wasm acgtk beluga bibtex2html coq2html coq_8_10 cryptoverif eff fstar glsurf iprover obelisk ocaml-crunch ocamlformat ocaml-top ocsigen-i18n patdiff pdfsandwich prooftree proverif reason satysfi stog

Copy link
Member

bcdarwin left a comment

Looks fine to me.

@bcdarwin
Copy link
Member

bcdarwin commented May 27, 2020

After this is merged we can bump ctypes and owl.

@vbgl vbgl merged commit 3f8d6d5 into NixOS:master May 27, 2020
21 checks passed
21 checks passed
editorconfig editorconfig
Details
acgtk, beluga, bibtex2html, coq2html, coq_8_10, cryptoverif, eff, flow, framac, fstar, glsurf, google-drive-ocamlfuse, hol_light, iprover, jackline, obelisk, ocaml-crunch, ocaml-top, ocamlformat, ocsigen-i18n, opam, ott, patdiff, pdfsandwich, prooftree, proverif, reason, satysfi, stog, vagrant, virt-top, wasm on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
acgtk, beluga, bibtex2html, coq2html, coq_8_10, cryptoverif, eff, flow, framac, fstar, glsurf, google-drive-ocamlfuse, hol_light, iprover, jackline, obelisk, ocaml-crunch, ocaml-top, ocamlformat, ocsigen-i18n, opam, ott, patdiff, pdfsandwich, prooftree, proverif, reason, satysfi, stog, vagrant, virt-top, wasm on aarch64-linux Success
Details
acgtk, beluga, bibtex2html, coq2html, coq_8_10, cryptoverif, eff, flow, framac, fstar, glsurf, google-drive-ocamlfuse, hol_light, iprover, jackline, obelisk, ocaml-crunch, ocaml-top, ocamlformat, ocsigen-i18n, opam, ott, patdiff, pdfsandwich, prooftree, proverif, reason, satysfi, stog, vagrant, virt-top, wasm on x86_64-linux Success
Details
flow, framac, google-drive-ocamlfuse, hol_light, jackline, opam, ott, vagrant, virt-top, wasm on aarch64-linux Success
Details
flow, framac, google-drive-ocamlfuse, hol_light, jackline, opam, ott, vagrant, virt-top, wasm on x86_64-darwin Success
Details
flow, framac, google-drive-ocamlfuse, hol_light, jackline, opam, ott, vagrant, virt-top, wasm on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="286e3df"; rev="286e3df73d22f3916f9c345dd5f9679f1997d720"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="286e3df"; rev="286e3df73d22f3916f9c345dd5f9679f1997d720"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="286e3df"; rev="286e3df73d22f3916f9c345dd5f9679f1997d720"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="286e3df"; rev="286e3df73d22f3916f9c345dd5f9679f1997d720"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="286e3df"; rev="286e3df73d22f3916f9c345dd5f9679f1997d720"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="286e3df"; rev="286e3df73d22f3916f9c345dd5f9679f1997d720"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="286e3df"; rev="286e3df73d22f3916f9c345dd5f9679f1997d720"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@vbgl vbgl deleted the vbgl:ocaml-default-4.10 branch May 27, 2020
@bcdarwin bcdarwin mentioned this pull request May 27, 2020
4 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.