Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions/editorconfig: disable until we can combine this with ofborg #88608

merged 1 commit into from May 22, 2020


Copy link

Mic92 commented May 22, 2020

Motivation for this change

#87853 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
@Mic92 Mic92 requested a review from zowoq May 22, 2020
@Mic92 Mic92 force-pushed the Mic92:editorconfig branch from 6aadc63 to f675dc6 May 22, 2020
We cannot run this check now, as it marks CI as green even though ofborg has not
evaluated it yet. In future we might be able to mark ofborg as a required test:
#87853 (comment)
@Mic92 Mic92 force-pushed the Mic92:editorconfig branch from f675dc6 to 8f40299 May 22, 2020
@zimbatm zimbatm merged commit 1ccf442 into NixOS:master May 22, 2020
@Mic92 Mic92 deleted the Mic92:editorconfig branch May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.